Cleaned up account info page #6547
Conversation
Removed code duplication in template, limited loading indication to the part of the template where actual loading happens (only the group membership info).
|
cc @kiranparajuli589 fyi |
| @click="$_oc_settingsAccount_getGroup" | ||
| </div> | ||
| <h2 v-translate class="oc-text-bold oc-text-initial oc-mb">Account Information</h2> | ||
| <dl class="account-page-info oc-flex oc-flex-wrap"> |
There was a problem hiding this comment.
mostly indentation changes from here on... only line 59 and following have actually changed.
|
Results for oC10Files2 https://drone.owncloud.com/owncloud/web/23364/17/1
|
|
Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23364/60/1 💥 The acceptance tests failed on retry. Please find the screenshots inside ...
webUISharingInternalUsers-shareWithUsers_feature-L342.png |
whelp... for the account info page we know that we only have 1 acceptance test (on purpose, changed in a recent PR). Restarted CI because that's obviously a flaky test... |
|
SonarCloud Quality Gate failed. |
Description
As a followup of #6522 I've removed code duplication in the template and limited the loading spinner to the part of the template where actual loading happens (only the group membership info). The rest of the account info page now loads immediately.
How Has This Been Tested?
Types of changes
Checklist: