[tests-only] Adds e2e tests for download files batch action #6541

SwikritiT · 2022-03-07T09:02:13Z

Description

Adds test implementation for step Alice downloads 2 files as tar.

Related Issue

Part of: e2e tests. Create public link story #6389

Motivation and Context

How Has This Been Tested?

local
CI

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests

Checklist:

Open tasks:

...

ownclouders · 2022-03-07T09:56:48Z

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23335/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23335/tracing/alice-creates-public-link-to-a-folder-alice-2022-3-7-09-54-44.zip

SwikritiT · 2022-03-09T04:08:15Z

The base branch needs to be merged first #6461

tests/e2e/support/page/files/allFiles.ts

tests/e2e/cucumber/step_definitions/app.files.ts

tests/e2e/support/page/files/allFiles.ts

tests/e2e/cucumber/publicLinkToFolderJourney.feature

tests/e2e/support/page/files/allFiles.ts

pascalwengerter

Please don't merge before @fschade has brought in his E2E improvements

SwikritiT · 2022-03-10T08:16:07Z

Please don't merge before @fschade has brought in his E2E improvements

@pascalwengerter Is it limited to this PR only? There is another PR too for the e2e tests #6461 that's ready to be merged. So let us know if we need to withhold that too.
Also, just out of curiosity what sort of improvements are we talking about?

fschade · 2022-04-07T16:06:20Z

is this still active or should we take over?

SwikritiT · 2022-04-08T03:34:20Z

is this still active or should we take over?

I was actually waiting for you to review it again. I have addressed your previous reviews. Can you take a look at it again?

fschade

Thanks for the PR, just some minor nitpicks.

tests/e2e/support/objects/app-files/resource/actions.ts

fschade · 2022-04-12T12:06:00Z

tests/e2e/support/objects/app-files/resource/actions.ts

+  folder: string
+}
+
+export const selectMultipleResources = async (args: selectResourcesArgs): Promise<void> => {


as reference for later, if we have selectRsources we also need a way to reset/deselect them again if a action on the same path should happen. No action item.

tests/e2e/cucumber/steps/app-files/resource.ts

SwikritiT · 2022-04-21T06:43:26Z

@fschade I've addressed your reviews can you take a look?

Signed-off-by: Swikriti Tripathi <[email protected]>

sonarqubecloud · 2022-04-29T05:54:04Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

pascalwengerter

LGTM, thanks for pushing through here!

pascalwengerter · 2022-04-29T08:48:01Z

tests/e2e/cucumber/features/integrations/link.oc10.feature

@@ -0,0 +1,35 @@
+Feature: link
+
+  @issue-6239


The linked issue has been resolved so after this PR has been merged we should be able to run the directory download tests for both backends (= remove the oc10 from the filename)

pascalwengerter · 2022-04-29T08:50:08Z

Also please use the squash-merge option here:)

fschade

LGTM 🎸

SwikritiT changed the base branch from master to unauthorizedUserOpenPublicLink March 7, 2022 09:02

SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from 05ecaae to f40d238 Compare March 7, 2022 09:38

SwikritiT self-assigned this Mar 7, 2022

SwikritiT mentioned this pull request Mar 7, 2022

e2e tests. Create public link story #6389

Closed

13 tasks

SwikritiT marked this pull request as ready for review March 9, 2022 04:08

SwikritiT requested review from pascalwengerter and fschade as code owners March 9, 2022 04:08

SwikritiT requested review from saw-jan, SagarGi, kiranparajuli589, amrita-shrestha and grgprarup March 9, 2022 04:09

amrita-shrestha reviewed Mar 9, 2022

View reviewed changes

tests/e2e/support/page/files/allFiles.ts Outdated Show resolved Hide resolved

SwikritiT commented Mar 9, 2022

View reviewed changes

tests/e2e/cucumber/step_definitions/app.files.ts Outdated Show resolved Hide resolved

SwikritiT requested a review from amrita-shrestha March 9, 2022 05:13

amrita-shrestha reviewed Mar 9, 2022

View reviewed changes

tests/e2e/support/page/files/allFiles.ts Outdated Show resolved Hide resolved

tests/e2e/cucumber/publicLinkToFolderJourney.feature Outdated Show resolved Hide resolved

SwikritiT requested a review from amrita-shrestha March 9, 2022 06:23

SwikritiT added the QA:team label Mar 9, 2022

saw-jan reviewed Mar 9, 2022

View reviewed changes

tests/e2e/support/page/files/allFiles.ts Outdated Show resolved Hide resolved

saw-jan reviewed Mar 9, 2022

View reviewed changes

tests/e2e/support/page/files/allFiles.ts Outdated Show resolved Hide resolved

pascalwengerter requested changes Mar 9, 2022

View reviewed changes

amrita-shrestha force-pushed the unauthorizedUserOpenPublicLink branch 2 times, most recently from 103143e to 62bf306 Compare March 10, 2022 03:17

SwikritiT force-pushed the downloadPubicLinkFiles branch from 6d46892 to 5c9ea1a Compare March 10, 2022 06:19

delete-merged-branch bot deleted the branch master March 14, 2022 03:55

SwikritiT changed the base branch from unauthorizedUserOpenPublicLink to master March 15, 2022 03:46

SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from 0e3d8d4 to 98e5ffc Compare April 5, 2022 03:59

SwikritiT force-pushed the downloadPubicLinkFiles branch 3 times, most recently from fccfcc6 to b4e626f Compare April 12, 2022 03:27

SwikritiT changed the title ~~[tests-only] Download files batch action~~ [tests-only] Adds e2e tests for download files batch action Apr 12, 2022

fschade suggested changes Apr 12, 2022

View reviewed changes

SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from 95d7e9f to 417e902 Compare April 13, 2022 04:02

SwikritiT requested a review from individual-it April 13, 2022 04:06

SwikritiT force-pushed the downloadPubicLinkFiles branch 2 times, most recently from b05f23d to 552d06b Compare April 19, 2022 03:53

SwikritiT mentioned this pull request Apr 19, 2022

[tests-only][do-not-merge]Test branch #6784

Closed

10 tasks

SwikritiT force-pushed the downloadPubicLinkFiles branch from 552d06b to 2172893 Compare April 20, 2022 04:22

SwikritiT requested a review from fschade April 20, 2022 05:20

SwikritiT force-pushed the downloadPubicLinkFiles branch from 175e544 to ccd6acf Compare April 25, 2022 04:02

SwikritiT added 2 commits April 29, 2022 09:40

Add test step for downloading file using batch action

2b8ec1d

Signed-off-by: Swikriti Tripathi <[email protected]>

Address reviews

72d51cf

SwikritiT force-pushed the downloadPubicLinkFiles branch from ccd6acf to ad36f30 Compare April 29, 2022 03:55

change selector

4db25e8

SwikritiT force-pushed the downloadPubicLinkFiles branch from a72fb45 to 4db25e8 Compare April 29, 2022 05:41

pascalwengerter approved these changes Apr 29, 2022

View reviewed changes

fschade approved these changes Apr 29, 2022

View reviewed changes

pascalwengerter merged commit efc2864 into master Apr 29, 2022

delete-merged-branch bot deleted the downloadPubicLinkFiles branch April 29, 2022 09:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tests-only] Adds e2e tests for download files batch action #6541

[tests-only] Adds e2e tests for download files batch action #6541

SwikritiT commented Mar 7, 2022 •

edited

Loading

ownclouders commented Mar 7, 2022

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23335/tracing/alice-creates-public-link-to-a-folder-alice-2022-3-7-09-54-44.zip

SwikritiT commented Mar 9, 2022

pascalwengerter left a comment

SwikritiT commented Mar 10, 2022

fschade commented Apr 7, 2022

SwikritiT commented Apr 8, 2022 •

edited

Loading

fschade left a comment

fschade Apr 12, 2022

SwikritiT commented Apr 21, 2022

sonarqubecloud bot commented Apr 29, 2022

pascalwengerter left a comment

pascalwengerter Apr 29, 2022

pascalwengerter commented Apr 29, 2022

fschade left a comment

[tests-only] Adds e2e tests for download files batch action #6541

[tests-only] Adds e2e tests for download files batch action #6541

Conversation

SwikritiT commented Mar 7, 2022 • edited Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

Open tasks:

ownclouders commented Mar 7, 2022

npx playwright show-trace https://cache.owncloud.com/public/owncloud/web/23335/tracing/alice-creates-public-link-to-a-folder-alice-2022-3-7-09-54-44.zip

SwikritiT commented Mar 9, 2022

pascalwengerter left a comment

Choose a reason for hiding this comment

SwikritiT commented Mar 10, 2022

fschade commented Apr 7, 2022

SwikritiT commented Apr 8, 2022 • edited Loading

fschade left a comment

Choose a reason for hiding this comment

fschade Apr 12, 2022

Choose a reason for hiding this comment

SwikritiT commented Apr 21, 2022

sonarqubecloud bot commented Apr 29, 2022

pascalwengerter left a comment

Choose a reason for hiding this comment

pascalwengerter Apr 29, 2022

Choose a reason for hiding this comment

pascalwengerter commented Apr 29, 2022

fschade left a comment

Choose a reason for hiding this comment

SwikritiT commented Mar 7, 2022 •

edited

Loading

SwikritiT commented Apr 8, 2022 •

edited

Loading