Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5310: Load thumbnails only for accepted shares #6534

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Fix #5310: Load thumbnails only for accepted shares #6534

merged 1 commit into from
Mar 4, 2022

Conversation

dschmidt
Copy link
Member

@dschmidt dschmidt commented Mar 4, 2022

Description

This enables thumbnails only for accepted shares.

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingPermToRoot https://drone.owncloud.com/owncloud/web/23300/35/1
The following scenarios passed on retry:

  • webUISharingPermissionToRoot/sharePermissionsUsers.feature:113

@dschmidt dschmidt mentioned this pull request Mar 4, 2022
Merged
9 tasks
pascalwengerter
pascalwengerter approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love a changelog item since it closes an issue but happy to have it in a subsequent PR to prevent unnecessary acceptance test runs (changelog-only PRs are efficient)

@pascalwengerter pascalwengerter merged commit 70709ee into master Mar 4, 2022
@delete-merged-branch delete-merged-branch bot deleted the share_thumbnails branch March 4, 2022 20:40
@dschmidt
Copy link
Member Author

dschmidt commented Mar 4, 2022 •
edited
Loading

was about to post: owncloud/owncloud-design-system#2007 is related hehehe

@pascalwengerter pascalwengerter mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent thumbnail loading for not accepted shares in "Shared with me" view
3 participants
@dschmidt @ownclouders @pascalwengerter