Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent thumbnail loading for not accepted shares in "Shared with me" view #5310

Closed
pascalwengerter opened this issue Jun 18, 2021 · 0 comments · Fixed by #6534
Closed

Prevent thumbnail loading for not accepted shares in "Shared with me" view #5310

pascalwengerter opened this issue Jun 18, 2021 · 0 comments · Fixed by #6534
Assignees
@dschmidt
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working

Comments

@pascalwengerter
Copy link
Contributor

Steps to reproduce

  1. User a shares image file with user b
  2. User b goes to "Shared with me" page and sees the pending shared image file
  3. 404 error in console for thumbnail preview of shared img

Expected behaviour

Preview is loaded asynchronously & displayed upon accepting the share

Actual behaviour

No differentiation loads to failing requests and console errors
@pascalwengerter pascalwengerter added Type:Bug Something isn't working Web-Fastlane labels Jun 18, 2021
@kulmann kulmann added Priority:p3-medium Normal priority Priority:p2-high Escalation, on top of current planning, release blocker and removed Priority:p3-medium Normal priority labels Dec 3, 2021
@dschmidt dschmidt self-assigned this Dec 11, 2021
dschmidt added a commit that referenced this issue Mar 4, 2022
@dschmidt
Fix #5310: Load thumbnails only for accepted shares
0d75482
@dschmidt dschmidt mentioned this issue Mar 4, 2022
Merged
10 tasks
pascalwengerter added a commit that referenced this issue Mar 4, 2022
@pascalwengerter
Merge pull request #6534 from owncloud/share_thumbnails
70709ee 
Fix #5310: Load thumbnails only for accepted shares
@kulmann kulmann moved this to Done in Web Support Board Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dschmidt dschmidt

Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug Something isn't working
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5310: Load thumbnails only for accepted shares owncloud/web
3 participants
@dschmidt @kulmann @pascalwengerter