Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load thumbnails for space images instead of the whole file #6529

Merged
merged 16 commits into from
Mar 8, 2022
Merged

Load thumbnails for space images instead of the whole file #6529

merged 16 commits into from
Mar 8, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 4, 2022 •
edited
Loading

Description

Enhancement: Load space images as preview

We've added a new logic which renders space images as preview to minimize data traffic

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Mar 4, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23292/69/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:115

@AlexAndBear AlexAndBear changed the title Load preview in projects.vue Load thumnails for space images instead of the whole file Mar 4, 2022
@AlexAndBear AlexAndBear force-pushed the space-images-as-thumbnails branch from 553a585 to 0a3b549 Compare March 5, 2022 13:13
@AlexAndBear AlexAndBear marked this pull request as ready for review March 5, 2022 13:14
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23309/67/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@AlexAndBear AlexAndBear requested a review from kulmann March 7, 2022 09:34
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23333/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@AlexAndBear AlexAndBear force-pushed the space-images-as-thumbnails branch from 959439f to ffd47be Compare March 7, 2022 12:30
@dschmidt dschmidt changed the title Load thumnails for space images instead of the whole file Load thumbnails for space images instead of the whole file Mar 7, 2022
@AlexAndBear AlexAndBear requested review from kulmann and dschmidt March 7, 2022 15:35
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23361/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

dschmidt
dschmidt reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍🏻

packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/mixins/spaces/actions/uploadImage.js Outdated Show resolved Hide resolved
@AlexAndBear AlexAndBear requested a review from dschmidt March 7, 2022 17:07
kulmann
kulmann approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

packages/web-app-files/src/index.js
@@ -138,5 +138,13 @@ export default {
store.getters.configuration.server || window.location.origin,
get(store, 'getters.capabilities.files.archivers', [])
)
// FIXME: Remove mock data
thumbnailService.initialize(
get(store, 'getters.capabilities.files.thumbnail', {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If guess we'll name it differently (like preview or something more generic), but that's not an issue for now. The way you implemented it allows a fix with minimal footprint ❤️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also check in the future if we can add supported mime types to the capabilities of oc10 as soon as the json schema for the capability is fixed.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait2 https://drone.owncloud.com/owncloud/web/23376/45/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10XGAPortrait1 https://drone.owncloud.com/owncloud/web/23376/44/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23378/61/1
The following scenarios passed on retry:

  • webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:165

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23378/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23378/68/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/shareByPublicLink.feature:108

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23378/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:143
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinRestore-trashbinRestore_feature-L279.png

webUITrashbinRestore-trashbinRestore_feature-L279.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10FileOperations https://drone.owncloud.com/owncloud/web/23382/14/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

59.0% 59.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear AlexAndBear merged commit 2002a93 into master Mar 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the space-images-as-thumbnails branch March 8, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

@JammingBen JammingBen Awaiting requested review from JammingBen

@dschmidt dschmidt Awaiting requested review from dschmidt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexAndBear @ownclouders @dschmidt @kulmann