Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outsource space readme content modal #6509

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Outsource space readme content modal #6509

merged 3 commits into from
Mar 2, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 2, 2022 •
edited
Loading

Description

Enhancement: Outsource space readme content modal

We've added a new component for space readme content modal and outsourced duplicated code.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@AlexAndBear AlexAndBear force-pushed the refactor-edit-description-modal branch from dc9375e to ff44665 Compare March 2, 2022 11:11
@AlexAndBear AlexAndBear force-pushed the refactor-edit-description-modal branch from f1a5e7d to 66f7eaa Compare March 2, 2022 12:52
@AlexAndBear AlexAndBear requested a review from kulmann March 2, 2022 12:59
@AlexAndBear AlexAndBear marked this pull request as ready for review March 2, 2022 12:59
pascalwengerter
pascalwengerter approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't like the "outsource" wording (I suppose "extract" would be better?) but we can change that in a changelog-only PR afterwards. Changes LGTM

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.6% 68.6% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23188/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:22

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23188/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@AlexAndBear AlexAndBear merged commit 2976911 into master Mar 2, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-edit-description-modal branch March 2, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @ownclouders @pascalwengerter