Fix "no selection" panel for root nodes in all files and public links #6505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
commented
Mar 2, 2022
| item: simpleOwnFolder, | ||
| selectedItems: [simpleOwnFolder], | ||
| mocks: { $client: { files: { fileInfo: mockFileInfo } } } | ||
| describe('file info', () => { |
There was a problem hiding this comment.
wrapped the file info related test cases into its own describe block, so the following lines are mostly indentation changes. Additional tests start in line 96.
There was a problem hiding this comment.
Needed to make some adjustments though, because I'm mocking buildResource now in this file.
|
Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23156/67/1
|
fschade
suggested changes
Mar 2, 2022
kulmann
force-pushed
the
fix-root-node-info-right-sidebar
branch
from
c271131 to
db22aa5
Compare
pascalwengerter
force-pushed
the
fix-root-node-info-right-sidebar
branch
from
b6dea90 to
f33196e
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We recently introduced a bug that causes the "no selection" info panel to not be shown anymore in the root of
All files(path ofAll filesroot changed from `` to/). This PR fixes it, also fixes it for public link roots (which have the public link token as first path segment) and adds unit tests for it.Also saw, that fetching the file info didn't work for public links (was using the fileInfo sdk method for authenticate files context). Fixed it as well. Didn't seem to hurt before, though, except for the console error about missing authentication.
Related Issue
Motivation and Context
Hardening.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: