Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] Bump oCIS commit id for the tests #6474

Merged
merged 5 commits into from
Mar 1, 2022
Merged

[tests-only][full-ci] Bump oCIS commit id for the tests #6474

merged 5 commits into from
Mar 1, 2022

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Feb 24, 2022

Description

Bump oCIS commit id to latest for the tests

Related Issue

part of owncloud/QA#726

Motivation and Context

How Has This Been Tested?

  • test environment: CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Feb 24, 2022
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23023/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23023/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-24-03-58-23.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23023/alice-shares-file-to-brian-alice-2022-2-24-03-59-28.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23023/alice-shares-folder-with-file-to-brian-alice-2022-2-24-04-00-32.zip

@saw-jan saw-jan mentioned this pull request Feb 24, 2022
Closed
13 tasks
@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23028/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23028/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-24-07-14-40.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23028/alice-shares-file-to-brian-alice-2022-2-24-07-14-49.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23028/alice-shares-folder-with-file-to-brian-alice-2022-2-24-07-14-59.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/23028/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23028/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-24-07-13-37.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23028/alice-shares-file-to-brian-alice-2022-2-24-07-14-44.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23028/alice-shares-folder-with-file-to-brian-alice-2022-2-24-07-15-52.zip

@saw-jan saw-jan force-pushed the bump-commitid-20220224 branch from dd652ae to 3cdf9bf Compare February 24, 2022 08:35
@ownclouders
Copy link
Contributor

Results for oCISFiles4 https://drone.owncloud.com/owncloud/web/23031/58/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFiles-batchAction_feature-L100.png

webUIFiles-batchAction_feature-L100.png

webUIFiles-batchAction_feature-L113.png

webUIFiles-batchAction_feature-L113.png

webUIFiles-batchAction_feature-L62.png

webUIFiles-batchAction_feature-L62.png

webUIFiles-batchAction_feature-L75.png

webUIFiles-batchAction_feature-L75.png

webUIFiles-batchAction_feature-L88.png

webUIFiles-batchAction_feature-L88.png

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal1 https://drone.owncloud.com/owncloud/web/23031/59/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups_feature-L244.png

webUISharingInternalGroups-shareWithGroups_feature-L244.png

@ownclouders
Copy link
Contributor

Results for oC10iPhone1 https://drone.owncloud.com/owncloud/web/23031/48/1
The following scenarios passed on retry:

  • webUIFilesCopy/copy.feature:12

@ownclouders
Copy link
Contributor

Results for oCISBasic https://drone.owncloud.com/owncloud/web/23031/51/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIAccount-accountInformation_feature-L10.png

webUIAccount-accountInformation_feature-L10.png

webUIAccount-accountInformation_feature-L20.png

webUIAccount-accountInformation_feature-L20.png

webUIAccount-accountInformation_feature-L34.png

webUIAccount-accountInformation_feature-L34.png

webUIPreview-imageMediaViewer_feature-L25.png

webUIPreview-imageMediaViewer_feature-L25.png

webUIPreview-imageMediaViewer_feature-L35.png

webUIPreview-imageMediaViewer_feature-L35.png

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/23031/60/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers_feature-L108.png

webUISharingInternalUsers-shareWithUsers_feature-L108.png

webUISharingInternalUsers-shareWithUsers_feature-L77.png

webUISharingInternalUsers-shareWithUsers_feature-L77.png

@ownclouders
Copy link
Contributor

Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/23031/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUILogin-openidLogin_feature-L22.png

webUILogin-openidLogin_feature-L22.png

webUILogin-openidLogin_feature-L29.png

webUILogin-openidLogin_feature-L29.png

webUIRenameFiles-renameFiles_feature-L183.png

webUIRenameFiles-renameFiles_feature-L183.png

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23031/61/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIResharing1-reshareUsers_feature-L198.png

webUIResharing1-reshareUsers_feature-L198.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L103.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L103.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L16.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L16.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L30.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L30.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L80.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L80.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L91.png

webUISharingInternalUsersShareWithPage-shareWithUsers_feature-L91.png

@ownclouders
Copy link
Contributor

Results for oCISFavorites https://drone.owncloud.com/owncloud/web/23031/54/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFavorites-favoritesFile_feature-L58.png

webUIFavorites-favoritesFile_feature-L58.png

@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 24, 2022
@ownclouders
Copy link
Contributor

Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/23033/57/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUILogin-openidLogin_feature-L22.png

webUILogin-openidLogin_feature-L22.png

webUILogin-openidLogin_feature-L29.png

webUILogin-openidLogin_feature-L29.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23033/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:199
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicManagement-shareByPublicLink_feature-L78.png

webUISharingPublicManagement-shareByPublicLink_feature-L78.png

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/23033/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:69

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal3 https://drone.owncloud.com/owncloud/web/23033/61/1
The following scenarios passed on retry:

  • webUISharingInternalUsersShareWithPage/shareWithUsers.feature:91

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/23033/55/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59
  • webUIDeleteFilesFolders/deleteFilesFolders.feature:98
  • webUIDeleteFilesFolders/deleteFilesFolders.feature:216

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23033/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUITrashbinDelete-trashbinDelete_feature-L105.png

webUITrashbinDelete-trashbinDelete_feature-L105.png

webUITrashbinRestore-trashbinRestore_feature-L46.png

webUITrashbinRestore-trashbinRestore_feature-L46.png

webUIUserJourney-journey1_feature-L11.png

webUIUserJourney-journey1_feature-L11.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23033/65/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L65.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L65.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23066/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUserJourney-journey1_feature-L11.png

webUIUserJourney-journey1_feature-L11.png

@saw-jan saw-jan force-pushed the bump-commitid-20220224 branch from 7530e86 to 66891c9 Compare February 25, 2022 06:20
@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23068/69/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUserJourney-journey1_feature-L10.png

webUIUserJourney-journey1_feature-L10.png

@saw-jan saw-jan force-pushed the bump-commitid-20220224 branch from 66891c9 to cd2ba6f Compare February 25, 2022 06:59
@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/23069/68/1
The following scenarios passed on retry:

  • webUISharingPublicDifferentRoles/shareByPublicLinkDifferentRoles.feature:169

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/23069/69/1
The following scenarios passed on retry:

  • webUITrashbinDelete/trashbinDelete.feature:105
  • webUITrashbinRestore/trashbinRestore.feature:84
💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUserJourney-journey1_feature-L10.png

webUIUserJourney-journey1_feature-L10.png

@pascalwengerter
Copy link
Contributor

@phil-davis please note the ping in the code review. With the oCIS commit ID the # in URLs for oCIS is gone, while OC10 still depends on it. We'll have to come up with a reasonable way of handling the different usage in test selectors, happy to discuss this in the QA meeting next Tuesday (we should be bumping oCIS commit ID regularly yes, but no need to hack sth today)

@saw-jan saw-jan force-pushed the bump-commitid-20220224 branch from cd2ba6f to 9b7c8bd Compare February 25, 2022 09:35
@saw-jan
Copy link
Member Author

saw-jan commented Feb 25, 2022

Need to have discussion on #6474 (comment)

@pascalwengerter pascalwengerter mentioned this pull request Feb 28, 2022
Closed
31 tasks
@pascalwengerter
Copy link
Contributor

Taking over here with @fschade to get this in before #6491, thanks for the groundwork 🙌🏽

@phil-davis
Copy link
Contributor

Feel free to rebase/squash/push/bump to a newer commit id/cherry-pick to somewhere else/whatever to get this passing.

@fschade fschade force-pushed the bump-commitid-20220224 branch 2 times, most recently from 4b7aadf to 44ac9c5 Compare March 1, 2022 05:26
@ownclouders
Copy link
Contributor

Results for oCISSharingPerm3 https://drone.owncloud.com/owncloud/web/23117/65/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L64.png

webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions_feature-L64.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/23117/67/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@phil-davis
Copy link
Contributor

Note: https://drone.owncloud.com/owncloud/web/23115/64/10
current nightly CI failed with:

{"level":"error","service":"storage","error":"unable to register services: rgrpc: error creating unary interceptor: eventsmiddleware,: error connecting to nats cluster test-cluster: stan: connect request timeout (possibly wrong cluster ID?)","time":"2022-03-01T02:02:59Z","message":"error starting the grpc server"}

Hopefully this PR will "fix" that sort of random failure, because we will be running a newer version of oCIS in CI.

@fschade
Copy link
Contributor

fschade commented Mar 1, 2022 •
edited
Loading

needs cs3org/reva#2596 for public link support

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pascalwengerter pascalwengerter marked this pull request as ready for review March 1, 2022 12:33
pascalwengerter
pascalwengerter approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🪂

packages/web-runtime/src/components/SidebarNav/SidebarNavItem.vue Outdated Show resolved Hide resolved
@fschade
fix e2e test page selectors
9e0787a 
skip explicit DOM date selection for public links
add nav name data property for sidebar nav records
@fschade fschade force-pushed the bump-commitid-20220224 branch from 44ac9c5 to 9e0787a Compare March 1, 2022 12:37
@kulmann kulmann merged commit 2325e47 into master Mar 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-commitid-20220224 branch March 1, 2022 12:40
@kulmann
Copy link
Member

kulmann commented Mar 1, 2022

force merged. last CI run was green, only removed a dev leftover in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fschade fschade fschade left review comments

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@saw-jan @ownclouders @phil-davis @pascalwengerter @fschade @kulmann