Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Redesign FilesTable #6450

Merged
merged 8 commits into from
Feb 21, 2022
Merged

[full-ci] Redesign FilesTable #6450

merged 8 commits into from
Feb 21, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Feb 17, 2022 •
edited
Loading

Description

See #6207

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests updated
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

Results for oCISWebdavLockProtection https://drone.owncloud.com/owncloud/web/22859/52/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@lookacat lookacat force-pushed the redesign-files-table branch from 2e2e6a6 to 0aeac07 Compare February 17, 2022 14:11
@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22870/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@kulmann
Copy link
Contributor

kulmann commented Feb 18, 2022

Could you please rebase this PR at some point? It's based on a pretty old commit. 😉

@lookacat
Copy link
Contributor Author

@kulmann yes will do a rebase before using the alpha ODS RC

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22929/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@lookacat lookacat force-pushed the redesign-files-table branch 2 times, most recently from 9dafd16 to 8a81650 Compare February 21, 2022 13:24
@lookacat lookacat changed the title replace highlight color with secondary Redesign FilesTable Feb 21, 2022
@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22935/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesList-sort_feature-L51.png

webUIFilesList-sort_feature-L51.png

webUIFilesList-sort_feature-L72.png

webUIFilesList-sort_feature-L72.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@lookacat lookacat changed the title Redesign FilesTable [full-ci] Redesign FilesTable Feb 21, 2022
@lookacat lookacat force-pushed the redesign-files-table branch from 8a81650 to cae3399 Compare February 21, 2022 13:54
@lookacat lookacat marked this pull request as ready for review February 21, 2022 13:54
fschade
fschade approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one small thing in the changelog, expect that LGTM 🚀

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22936/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesList-sort_feature-L51.png

webUIFilesList-sort_feature-L51.png

webUIFilesList-sort_feature-L72.png

webUIFilesList-sort_feature-L72.png

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/22936/56/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesList-sort_feature-L51.png

webUIFilesList-sort_feature-L51.png

webUIFilesList-sort_feature-L72.png

webUIFilesList-sort_feature-L72.png

@lookacat lookacat force-pushed the redesign-files-table branch from de90663 to 7cdd632 Compare February 21, 2022 14:56
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22939/55/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:21

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22939/69/1
The following scenarios passed on retry:

  • webUIUserJourney/journey1.feature:11

@lookacat lookacat merged commit 688d5f8 into master Feb 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-files-table branch February 21, 2022 15:40
amrita-shrestha pushed a commit that referenced this pull request Feb 22, 2022
@lookacat @amrita-shrestha
[full-ci] Redesign FilesTable (#6450)
da078f5 
* replace highlight color with secondary

* replace highlight color with secondary

* Adjust theming colors

* Add changelog

* Address PR issue comments

* Use ODS 12.1.1-rc1

* Update snapshots

* Fix sort acceptance test selector, improve changelog content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann left review comments

@fschade fschade fschade approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign "Files Table"
4 participants
@lookacat @ownclouders @kulmann @fschade