-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not load files from cache #6447
Do not load files from cache #6447
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thank you!
Results for oCISSharingPerm2 https://drone.owncloud.com/owncloud/web/22851/64/1 |
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/22874/16/1 💥 The acceptance tests pipeline failed. The build has been cancelled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't get why the markdowneditor failed for this in CI, just ran the acceptance tests locally with the CERN web
and it worked flawlessly 🤷🏽 restarting CI, let's see!
Kudos, SonarCloud Quality Gate passed! |
Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/23045/10/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-24-06-52-48.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-creates-public-link-to-a-folder-alice-2022-2-24-06-53-54.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-shares-file-to-brian-alice-2022-2-24-06-55-04.zipnpx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/23045/alice-shares-folder-with-file-to-brian-alice-2022-2-24-06-56-14.zip |
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache * changelog
* Do not load files from cache (#6447) * Do not load files from cache * changelog * Workaround CORS issue until owncloud/core#40024 is merged and released * Update changelog with further information on Cache-Control header Co-authored-by: Diogo Castro <[email protected]> Co-authored-by: Dominik Schmidt <[email protected]>
When apps (i.e Drawio) try to load a file, the browser caches the request.
If the file was modified somewhere else, this causes inconsistent results which prevent saving any changes until the cache is properly cleared.
We had observed this is the past in our text editor, hence the
noCache
addition to the SDK. Now we also saw it in Drawio.