Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load files from cache #6447

Merged

Conversation

diocas
Copy link
Contributor

@diocas diocas commented Feb 17, 2022

When apps (i.e Drawio) try to load a file, the browser caches the request.
If the file was modified somewhere else, this causes inconsistent results which prevent saving any changes until the cache is properly cleared.

We had observed this is the past in our text editor, hence the noCache addition to the SDK. Now we also saw it in Drawio.

@update-docs
Copy link

update-docs bot commented Feb 17, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm2 https://drone.owncloud.com/owncloud/web/22851/64/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/22874/16/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIMarkdownEditor-markdownFile_feature-L21.png

webUIMarkdownEditor-markdownFile_feature-L21.png

webUIMarkdownEditor-markdownFile_feature-L29.png

webUIMarkdownEditor-markdownFile_feature-L29.png

webUIMarkdownEditor-markdownFile_feature-L44.png

webUIMarkdownEditor-markdownFile_feature-L44.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't get why the markdowneditor failed for this in CI, just ran the acceptance tests locally with the CERN web and it worked flawlessly 🤷🏽 restarting CI, let's see!

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
No Duplication information No Duplication information

@pascalwengerter pascalwengerter changed the base branch from master to transfer-no-drawio-cache February 24, 2022 19:23
@pascalwengerter pascalwengerter merged commit 7f1629b into owncloud:transfer-no-drawio-cache Feb 24, 2022
@pascalwengerter pascalwengerter mentioned this pull request Feb 24, 2022
pascalwengerter pushed a commit that referenced this pull request Feb 24, 2022
* Do not load files from cache

* changelog
@pascalwengerter pascalwengerter mentioned this pull request Feb 24, 2022
phil-davis pushed a commit that referenced this pull request Feb 28, 2022
* Do not load files from cache

* changelog
kiranparajuli589 pushed a commit that referenced this pull request Mar 2, 2022
* Do not load files from cache

* changelog
kiranparajuli589 pushed a commit that referenced this pull request Mar 9, 2022
* Do not load files from cache

* changelog
kiranparajuli589 pushed a commit that referenced this pull request Mar 10, 2022
* Do not load files from cache

* changelog
kiranparajuli589 pushed a commit that referenced this pull request Mar 16, 2022
* Do not load files from cache

* changelog
kiranparajuli589 pushed a commit that referenced this pull request Mar 23, 2022
* Do not load files from cache

* changelog
dschmidt pushed a commit that referenced this pull request Apr 26, 2022
* Do not load files from cache

* changelog
pascalwengerter pushed a commit that referenced this pull request Apr 27, 2022
* Do not load files from cache (#6447)

* Do not load files from cache

* changelog

* Workaround CORS issue until owncloud/core#40024 is merged and released

* Update changelog with further information on Cache-Control header

Co-authored-by: Diogo Castro <[email protected]>
Co-authored-by: Dominik Schmidt <[email protected]>
@micbar micbar mentioned this pull request May 5, 2022
45 tasks
@diocas diocas deleted the files_loading branch February 15, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants