Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement right sidebar for spaces #6437

Merged
merged 8 commits into from
Feb 19, 2022
Merged

Implement right sidebar for spaces #6437

merged 8 commits into from
Feb 19, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Feb 15, 2022 •
edited
Loading

Description

This PR introduces the basic space sidebar. Some things that need to come later:

  • People- and Link-Management (will be a separate PR as this is a bigger story)
  • Edit Image, Subtitle, Description (see Add set as space img/md action #6410)
  • Permissions (also a separate PR, needs to be done everywhere for spaces)

Related Issue

Screenshots

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen self-assigned this Feb 15, 2022
@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22762/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/22762/36/1
The following scenarios passed on retry:

  • webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:11

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22775/69/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10IntegrationNotifications https://drone.owncloud.com/owncloud/web/22775/70/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22775/68/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22775/67/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingPerm1 https://drone.owncloud.com/owncloud/web/22775/63/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@owncloud owncloud deleted a comment from update-docs bot Feb 15, 2022
@JammingBen JammingBen marked this pull request as ready for review February 15, 2022 13:18
@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22798/55/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:50

AlexAndBear
AlexAndBear reviewed Feb 16, 2022
View reviewed changes
packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue
const loadOwnersTask = useTask(function* (signal, ref) {
const promises = []
for (const userId of ref.ownerUserIds) {
promises.push(graphClient.users.getUser(userId))
Copy link
Contributor

@AlexAndBear AlexAndBear Feb 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might call listUsers in the API and call and filter the users, to do only one request

@AlexAndBear
Copy link
Contributor

AlexAndBear commented Feb 16, 2022 •
edited
Loading

LGTM, needs some adjustments along with #6410 in a separate pr

kulmann
kulmann requested changes Feb 17, 2022
View reviewed changes
changelog/unreleased/enhancement-spaces-sidebar Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/Details/SpaceDetails.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/SideBar.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/SideBar.vue Show resolved Hide resolved
packages/web-app-files/src/components/SideBar/SpaceInfo.vue Outdated Show resolved Hide resolved
packages/web-app-files/src/mixins/spaces/actions/showDetails.js Show resolved Hide resolved
@JammingBen
Copy link
Contributor Author

SonarCloud Quality Gate failed.

I knew it 🥲 Tests for the quota component incoming...

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22883/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22883/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@JammingBen JammingBen requested a review from kulmann February 18, 2022 09:22
@ownclouders
Copy link
Contributor

Results for oCISFiles3 https://drone.owncloud.com/owncloud/web/22886/57/1
The following scenarios passed on retry:

  • webUIRenameFiles/renameFiles.feature:257

@ownclouders
Copy link
Contributor

Results for oCISFiles2 https://drone.owncloud.com/owncloud/web/22886/56/1
The following scenarios passed on retry:

  • webUIFilesList/fileList.feature:55

kulmann
kulmann approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

packages/web-app-files/src/mixins/spaces/actions/showDetails.js Show resolved Hide resolved
packages/web-app-files/src/components/SpaceQuota.vue
case 'nearing':
return 'warning'
case 'critical':
return 'warning'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't critical be danger already? 🤔

@ownclouders
Copy link
Contributor

Results for oCISFiles4 https://drone.owncloud.com/owncloud/web/22904/58/1
The following scenarios passed on retry:

  • webUIFiles/download.feature:11

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22904/66/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L94.png

webUIUpload-upload_feature-L94.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

56.6% 56.6% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22906/60/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@kulmann kulmann merged commit 2abfe48 into master Feb 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the spaces-sidebar branch February 19, 2022 00:41
@JammingBen JammingBen mentioned this pull request Feb 28, 2022
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JammingBen @ownclouders @AlexAndBear @kulmann