Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the graph client to the client service #6425

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Add the graph client to the client service #6425

merged 2 commits into from
Feb 11, 2022

Conversation

JammingBen
Copy link
Contributor

Description

This way, the client for the graph API can easily be fetched when needed.

Motivation and Context

Groundwork for #6284 (and basically any other space-related issue)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.0% 72.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review February 11, 2022 13:04
@JammingBen JammingBen requested a review from kulmann February 11, 2022 13:04
@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22692/66/1
The following scenarios passed on retry:

  • webUIUpload/upload.feature:94

kulmann
kulmann approved these changes Feb 11, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kulmann kulmann merged commit f0213cc into master Feb 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the graph-client-service branch February 11, 2022 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JammingBen @ownclouders @kulmann