Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] stub oc-list element in ApplicationsMenu unit tests #6406

Conversation

individual-it
Copy link
Member

Description

stub the oc-list element that was added recently
@pascalwengerter you have added the element in f9f17d6 , any reason not to stub it?

Related Issue

Motivation and Context

reduce log output saying
[Vue warn]: Unknown custom element: <oc-list> - did you register the component correctly? For recursive components, make sure to provide the "name" option.

How Has This Been Tested?

  • running unit tests locally
  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it force-pushed the reduceLogOutput/web-runtime/tests/unit/components/Topbar/ApplicationsMenu.spec.js branch from 58ed5b4 to fbbf389 Compare February 10, 2022 03:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care!

@pascalwengerter pascalwengerter merged commit 69b55c4 into master Feb 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the reduceLogOutput/web-runtime/tests/unit/components/Topbar/ApplicationsMenu.spec.js branch February 10, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants