Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Redesign New- and Upload-Buttons #6358

Merged
merged 4 commits into from
Feb 24, 2022
Merged

[full-ci] Redesign New- and Upload-Buttons #6358

merged 4 commits into from
Feb 24, 2022

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented Feb 2, 2022 •
edited
Loading

Related Issue

Types of changes

  • New feature (non-breaking change which adds functionality)
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

@update-docs
Copy link

update-docs bot commented Feb 2, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter changed the title Save first draft, to be reverted Redesign New- and Upload-Buttons Feb 2, 2022
@pascalwengerter pascalwengerter changed the title Redesign New- and Upload-Buttons [full-ci] Redesign New- and Upload-Buttons Feb 15, 2022
@pascalwengerter pascalwengerter force-pushed the split-new-upload-btn branch 2 times, most recently from 39f2d87 to 1b231c6 Compare February 15, 2022 13:26
@pascalwengerter pascalwengerter marked this pull request as ready for review February 15, 2022 13:28
@pascalwengerter pascalwengerter requested review from kulmann and removed request for fschade February 15, 2022 13:28
@pascalwengerter
Copy link
Contributor Author

Could use some unit test polishing though, happy about a quick first review

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22786/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22786/alice-shares-file-to-brian-alice-2022-2-15-01-38-02.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22786/alice-shares-file-to-brian-brian-2022-2-15-01-38-06.zip

@pascalwengerter pascalwengerter force-pushed the split-new-upload-btn branch 4 times, most recently from 91de749 to eb95b41 Compare February 15, 2022 15:08
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22797/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22797/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-15-03-17-02.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22797/alice-shares-file-to-brian-alice-2022-2-15-03-18-09.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22797/alice-shares-folder-with-file-to-brian-alice-2022-2-15-03-19-15.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22797/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22797/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-15-03-18-04.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22797/alice-shares-file-to-brian-alice-2022-2-15-03-19-15.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22797/alice-shares-folder-with-file-to-brian-alice-2022-2-15-03-20-26.zip

@dschmidt dschmidt force-pushed the split-new-upload-btn branch from a867762 to 0b4ccdd Compare February 16, 2022 19:18
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/22845/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22845/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-17-12-05-25.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22845/alice-shares-file-to-brian-alice-2022-2-17-12-06-39.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22845/alice-shares-folder-with-file-to-brian-alice-2022-2-17-12-07-46.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/22845/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22845/alice-can-share-this-weeks-meal-plan-with-all-parents-alice-2022-2-17-12-06-54.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22845/alice-shares-file-to-brian-alice-2022-2-17-12-08-16.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/22845/alice-shares-folder-with-file-to-brian-alice-2022-2-17-12-09-31.zip

@ownclouders
Copy link
Contributor

Results for oC10Upload https://drone.owncloud.com/owncloud/web/22862/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L69.png

webUIUpload-upload_feature-L69.png

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22862/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L129.png

webUIFilesSearch-search_feature-L129.png

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/22862/72/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L69.png

webUIUpload-upload_feature-L69.png

@ownclouders
Copy link
Contributor

Results for oC10Move https://drone.owncloud.com/owncloud/web/22862/21/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIOperationsWithFolderShares-accessToSharesFolder_feature-L62.png

webUIOperationsWithFolderShares-accessToSharesFolder_feature-L62.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22862/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/22862/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22862/66/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L69.png

webUIUpload-upload_feature-L69.png

@ownclouders
Copy link
Contributor

Results for oC10Upload https://drone.owncloud.com/owncloud/web/22877/38/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L69.png

webUIUpload-upload_feature-L69.png

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22877/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L129.png

webUIFilesSearch-search_feature-L129.png

@ownclouders
Copy link
Contributor

Results for oC10Move https://drone.owncloud.com/owncloud/web/22877/21/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIOperationsWithFolderShares-accessToSharesFolder_feature-L62.png

webUIOperationsWithFolderShares-accessToSharesFolder_feature-L62.png

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic2 https://drone.owncloud.com/owncloud/web/22877/68/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/22877/72/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L69.png

webUIUpload-upload_feature-L69.png

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic2 https://drone.owncloud.com/owncloud/web/22877/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L159.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L169.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L199.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles_feature-L209.png

@ownclouders
Copy link
Contributor

Results for oCISSharingAndUpload https://drone.owncloud.com/owncloud/web/22877/66/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L188.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L22.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L55.png

webUIUpload-upload_feature-L69.png

webUIUpload-upload_feature-L69.png

@kulmann kulmann force-pushed the split-new-upload-btn branch from 369118a to 557e16d Compare February 18, 2022 20:51
kulmann
kulmann approved these changes Feb 18, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎨

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22900/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L129.png

webUIFilesSearch-search_feature-L129.png

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/22900/72/1
The following scenarios passed on retry:

  • webUIUpload/uploadFileGreaterThanQuotaSize.feature:12

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22900/69/1
The following scenarios passed on retry:

  • webUIUserJourney/journey1.feature:11

@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22902/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L129.png

webUIFilesSearch-search_feature-L129.png

@kulmann kulmann force-pushed the split-new-upload-btn branch from 557e16d to af30d92 Compare February 18, 2022 22:56
@ownclouders
Copy link
Contributor

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/22905/17/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFilesSearch-search_feature-L129.png

webUIFilesSearch-search_feature-L129.png

@ownclouders
Copy link
Contributor

Results for oCISTrashbinUploadMoveJourney https://drone.owncloud.com/owncloud/web/22905/69/1
The following scenarios passed on retry:

  • webUIUserJourney/journey1.feature:11

@kulmann
Copy link
Member

kulmann commented Feb 18, 2022

webUIFilesSearch/search.feature:129 fails reliably. Needs to be looked at...

@pascalwengerter pascalwengerter mentioned this pull request Feb 24, 2022
Closed
3 tasks
@pascalwengerter
Copy link
Contributor Author

webUIFilesSearch/search.feature:129 fails reliably. Needs to be looked at...

No clue why but navigating didn't work before the upload happened, changed code in c17bbce to make it pass

pascalwengerter and others added 2 commits February 24, 2022 19:17
@pascalwengerter
Separate 'create new file/folder' and 'upload files/folder' actions i…
4b1faca 
…nto two dropdowns

Extract create/upload from appBar into new component
@dschmidt @pascalwengerter
Fix #5530: Upsert new files into files list
2ebe252 
Check for http and https for external image icon sources

Remove paddings in new and upload menus

Remove line break for standalone new folder button

Separate unit tests for AppBar and CreateAndUpload

Fix file and folder upload postprocessing

Fix search CI

Minor dependency bumps
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/23047/15/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAcceptSharesToRoot-acceptShares_feature-L108.png

webUISharingAcceptSharesToRoot-acceptShares_feature-L108.png

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug B 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 2 Code Smells

16.1% 16.1% Coverage
2.4% 2.4% Duplication

@pascalwengerter
Copy link
Contributor Author

I have some (incomplete) test refactoring locally, but will provide these when working on the subsequent changes in #6351

@pascalwengerter pascalwengerter merged commit 5578d08 into master Feb 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the split-new-upload-btn branch February 24, 2022 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redesign New-Button (v1)
4 participants
@pascalwengerter @ownclouders @kulmann @dschmidt