Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Bump the commit id for tests #6257

Merged
merged 1 commit into from
Jan 25, 2022
Merged

[tests-only][full-ci]Bump the commit id for tests #6257

merged 1 commit into from
Jan 25, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jan 14, 2022 •
edited by phil-davis
Loading

Description

Test scenarios are adjusted to take into account that the Shares folder is always displayed when running on oCIS, even before a user has received any incoming share.

This also means that test scenarios that try to "select all" and then "delete all" at the top (root) level a a user's file system do not pass. The Shares folder gets selected, but it cannot be deleted. See issue #6305 for discussion of this.

Also, the media viewer test code has been enhanced to waitForMediaViewerLoaded to help be sure that the resource has been properly loaded at each point in the test steps.

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT marked this pull request as draft January 14, 2022 03:40
@SwikritiT SwikritiT mentioned this pull request Jan 14, 2022
Closed
9 tasks
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/21888/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21888/2022-1-14-03-48-55-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21888/2022-1-14-03-49-44-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21888/2022-1-14-03-50-21-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21888/2022-1-14-03-50-58-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21888/2022-1-14-03-51-37-Alice.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/21889/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21889/2022-1-14-04-26-12-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21889/2022-1-14-04-26-55-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21889/2022-1-14-04-27-30-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21889/2022-1-14-04-28-05-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21889/2022-1-14-04-28-41-Alice.zip

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/21890/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21890/2022-1-14-04-38-29-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21890/2022-1-14-04-39-17-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21890/2022-1-14-04-39-54-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21890/2022-1-14-04-40-30-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21890/2022-1-14-04-41-08-Alice.zip

@SwikritiT SwikritiT force-pushed the bump-commit-id-20220114 branch from 1917a2e to e4c15e7 Compare January 14, 2022 04:46
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/21891/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21891/2022-1-14-04-55-27-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21891/2022-1-14-04-56-14-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21891/2022-1-14-04-56-51-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21891/2022-1-14-04-57-27-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21891/2022-1-14-04-58-05-Alice.zip

@fschade fschade mentioned this pull request Jan 14, 2022
Closed
@SwikritiT SwikritiT force-pushed the bump-commit-id-20220114 branch from e4c15e7 to a219169 Compare January 14, 2022 10:42
@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/21905/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21905/2022-1-14-10-52-00-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21905/2022-1-14-10-52-49-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21905/2022-1-14-10-53-30-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21905/2022-1-14-10-54-09-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21905/2022-1-14-10-54-49-Alice.zip

@ScharfViktor
Copy link
Contributor

E2e tests caught an error here and with tracing it is easy to survey this.
Don't be shy, ask me. I'll be glad to help you.

What I do by example #6257 (comment):

  • go to https://drone.owncloud.com/owncloud/web/21905/11/1
    I see that tests was failed by step (It was first fail):
    image

  • I open first trace in console npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21905/2022-1-14-10-52-00-Alice.zip and go to the place where the failure happened.
    Screenshot 2022-01-14 at 14 28 45

  • Here is problem why button Share was disable:
    Screenshot 2022-01-14 at 14 11 48

@ScharfViktor
Copy link
Contributor

ScharfViktor commented Jan 14, 2022 •
edited
Loading

I created bug: owncloud/ocis#2966

@SwikritiT SwikritiT force-pushed the bump-commit-id-20220114 branch from a219169 to 16bc5b2 Compare January 17, 2022 03:50
@SwikritiT
Copy link
Contributor Author

SwikritiT commented Jan 17, 2022 •
edited
Loading

I created bug: owncloud/ocis#2966

Thank you for your help. Can I skip those tests or add them somewhere so that the pipeline won't fail? This PR will be blocked and the id won't be bumped if the tests keep failing in e2e-tests oCIS.

@ownclouders
Copy link
Contributor

Results for e2e-tests oCIS https://drone.owncloud.com/owncloud/web/21931/11/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21931/2022-1-17-04-46-10-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21931/2022-1-17-04-47-00-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21931/2022-1-17-04-47-37-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21931/2022-1-17-04-48-14-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21931/2022-1-17-04-48-53-Alice.zip

@SwikritiT SwikritiT self-assigned this Jan 17, 2022
@ScharfViktor
Copy link
Contributor

I created bug: owncloud/ocis#2966

Thank you for your help. Can I skip those tests or add them somewhere so that the pipeline won't fail? This PR will be blocked and the id won't be bumped if the tests keep failing in e2e-tests oCIS.

I can change failed tests. For example, select the user by email or name. Can I add my changes here or should I create another PR?

@phil-davis
Copy link
Contributor

I can change failed tests. For example, select the user by email or name. Can I add my changes here or should I create another PR?

Yes, please push to this PR. And I see that you already did that - thanks.

@ownclouders
Copy link
Contributor

Results for e2e-tests oC10 https://drone.owncloud.com/owncloud/web/21934/10/1

💥 To see the trace, please open the link in the console ...

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-53-20-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-53-37-Brian.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-54-14-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-54-21-Brian.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-54-57-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-55-04-Brian.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-55-41-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-55-49-Brian.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-56-26-Alice.zip

npx playwright show-trace https://cache.owncloud.com/owncloud/web/tracing/21934/2022-1-17-08-56-35-Brian.zip

@ScharfViktor
Copy link
Contributor

Wow. It is funny.

  • Select user by full name doesn't work in oCIS
  • Select user by email doesn't work in oC10

It's a good thing we have some in reserve "choose by name". It works in oCis and oC10.

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/21937/58/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@ScharfViktor
Copy link
Contributor

@phil-davis e2e tests passed, but some acceptance tests failed. Do you need help finding the problem?

@phil-davis
Copy link
Contributor

@phil-davis e2e tests passed, but some acceptance tests failed. Do you need help finding the problem?

I swill post the details of fails now - and then think...

@phil-davis
Copy link
Contributor

I rebased and bumped the oCIS commit id to the latest. Let's see what CI result we get, then I will sort out expected-failures...

@phil-davis phil-davis force-pushed the bump-commit-id-20220114 branch from fd5ec70 to b97a3ce Compare January 24, 2022 16:13
@SwikritiT SwikritiT marked this pull request as ready for review January 25, 2022 03:17
@phil-davis
Copy link
Contributor

I will have a look at what diffs are remaining in this PR - maybe we can sort out some other test scenarios that are no longer relevant to running on oCIS.

@phil-davis
Copy link
Contributor

I made a few adjustments to tests, so I expect some different scenario line numbers that I will need to adjust. And I raised issue #6305 - I will put that in expected-failures here in the next push. And that can be discussed swhen other people come online. Then we can again move forward with this commit id bump...

@ownclouders
Copy link
Contributor

Results for oC10FileOperations https://drone.owncloud.com/owncloud/web/22135/14/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders_feature-L133.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L133.png

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/22135/53/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingAcceptShares-acceptShares_feature-L162.png

webUISharingAcceptShares-acceptShares_feature-L162.png

webUISharingAcceptShares-acceptShares_feature-L201.png

webUISharingAcceptShares-acceptShares_feature-L201.png

webUISharingAcceptShares-acceptShares_feature-L228.png

webUISharingAcceptShares-acceptShares_feature-L228.png

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22135/55/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders_feature-L133.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L133.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L89.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L89.png

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22138/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10SharingPublic1 https://drone.owncloud.com/owncloud/web/22138/37/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L147.png

webUISharingPublicExpire-shareByPublicLinkExpiringLinks_feature-L147.png

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/22138/55/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIDeleteFilesFolders-deleteFilesFolders_feature-L89.png

webUIDeleteFilesFolders-deleteFilesFolders_feature-L89.png

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/web/22138/37/21
webUISharingPublicExpire/shareByPublicLinkExpiringLinks.feature:147 failed - that seems unrelated to everything that has been happening in this PR! Maybe that is another flaky test?

@phil-davis phil-davis force-pushed the bump-commit-id-20220114 branch from 5c0dcfa to 365bef4 Compare January 25, 2022 05:54
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/22142/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oCISSharingInternal2 https://drone.owncloud.com/owncloud/web/22142/58/1
The following scenarios passed on retry:

  • webUISharingInternalUsers/shareWithUsers.feature:342

@saw-jan saw-jan mentioned this pull request Jan 25, 2022
Closed
10 tasks
@phil-davis phil-davis force-pushed the bump-commit-id-20220114 branch from 365bef4 to d372ffa Compare January 25, 2022 06:38
@phil-davis
Copy link
Contributor

phil-davis commented Jan 25, 2022 •
edited
Loading

@kulmann this is ready for review. The main ToDo is to get an opinion on issue #6305 and then either the changes here are good-to-go or I need to adjust test scenario webUIDeleteFilesFolders/deleteFilesFolders.feature:77

@ownclouders
Copy link
Contributor

Results for oCISSharingPublic1 https://drone.owncloud.com/owncloud/web/22149/64/1
The following scenarios passed on retry:

  • webUISharingPublicBasic/publicLinkCreate.feature:190

@phil-davis phil-davis force-pushed the bump-commit-id-20220114 branch from d372ffa to 9f760a2 Compare January 25, 2022 08:46
@sonarcloud
Copy link

sonarcloud bot commented Jan 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis
Copy link
Contributor

phil-davis commented Jan 25, 2022 •
edited
Loading

I will merge. If there is a different answer/decision about the required behavior of #6305 then we will make a separate PR to adjust the related test scenario

@phil-davis phil-davis merged commit cef5894 into master Jan 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-20220114 branch January 25, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann kulmann approved these changes

@individual-it individual-it individual-it approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SwikritiT @ownclouders @ScharfViktor @phil-davis @individual-it @kulmann @pascalwengerter