-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Show path / parent folder to distinguish files #6226
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
95c62ac
to
b4c4046
Compare
Results for oC10SharingPermission https://drone.owncloud.com/owncloud/web/21749/35/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/21760/16/1
|
Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/21760/68/1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! 🤩
One thing that I found: when you click on the folder in the search preview, the navigation to the folder works, but there is an error in the browser console: Error in v-on handler: "TypeError: action.handler is not a function"
.
571e476
to
c646c8a
Compare
Ok, found the reason for it, but will fix it in another PR because it needs owncloud/owncloud-design-system#1871 to be merged and released. Error is not introduced by this PR anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
3f498b4
to
b97e049
Compare
Kudos, SonarCloud Quality Gate passed! |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21839/15/1
|
Description
See #5953
Related Issue
Types of changes
Checklist: