Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Show path / parent folder to distinguish files #6226

Merged
merged 6 commits into from
Jan 13, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Jan 6, 2022

Description

See #5953

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Jan 6, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat force-pushed the feat-show-parent-folder-name branch from 95c62ac to b4c4046 Compare January 10, 2022 13:42
@lookacat lookacat marked this pull request as ready for review January 11, 2022 10:37
@lookacat lookacat changed the title Show path / parent folder to distinguish files [full-ci] Show path / parent folder to distinguish files Jan 11, 2022
@ownclouders
Copy link
Contributor

Results for oC10SharingPermission https://drone.owncloud.com/owncloud/web/21749/35/1
The following scenarios passed on retry:

  • webUISharingPermissionsUsers/sharePermissionsUsers.feature:103

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/21760/16/1
The following scenarios passed on retry:

  • webUIMarkdownEditor/markdownFile.feature:29

@ownclouders
Copy link
Contributor

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/21760/68/1
The following scenarios passed on retry:

  • webUIPrivateLinks/accessingPrivateLinks.feature:17

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! 🤩

One thing that I found: when you click on the folder in the search preview, the navigation to the folder works, but there is an error in the browser console: Error in v-on handler: "TypeError: action.handler is not a function".

@kulmann kulmann force-pushed the feat-show-parent-folder-name branch from 571e476 to c646c8a Compare January 12, 2022 13:45
@kulmann
Copy link
Contributor

kulmann commented Jan 12, 2022

One thing that I found: when you click on the folder in the search preview, the navigation to the folder works, but there is an error in the browser console: Error in v-on handler: "TypeError: action.handler is not a function".

Ok, found the reason for it, but will fix it in another PR because it needs owncloud/owncloud-design-system#1871 to be merged and released. Error is not introduced by this PR anyway.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pascalwengerter pascalwengerter force-pushed the feat-show-parent-folder-name branch from 3f498b4 to b97e049 Compare January 13, 2022 09:32
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/21839/15/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@kulmann kulmann merged commit f0641d6 into master Jan 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the feat-show-parent-folder-name branch January 13, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants