-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(resource loading): don't load root resources twice if homeFolder is set #5893
Conversation
Results for oC10SharingInternalUsersBlacklisted https://drone.owncloud.com/owncloud/web/19520/26/1 |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19522/11/1
|
Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/19522/9/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19522/12/1
|
get rid of uunnecessary resource loading for personal files view if homeFolder is set.
fb39ae2
to
bdaef9f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found a bug: when you're in the root folder of All files
you don't get redirected to the homeFolder anymore when clicking on the All files
menu item.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
SonarCloud Quality Gate failed. |
Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19615/11/1
|
Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19615/12/1
|
Description
in some cases it could happen that resources get loaded twice.
This happens in the Personal view (all files) if a homeFolder is configured.
This pr takes care of it by returning early before any root resources gets loaded.
This is not a final solution and should be considered when working on the architecture in general.
Related Issue
Motivation and Context
don't send unnecessary requests
How Has This Been Tested?
local installation with latest master of ocis
Screenshots (if appropriate):
Types of changes
Open tasks: