Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource loading): don't load root resources twice if homeFolder is set #5893

Merged
merged 4 commits into from
Oct 13, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Oct 10, 2021

Description

in some cases it could happen that resources get loaded twice.
This happens in the Personal view (all files) if a homeFolder is configured.

This pr takes care of it by returning early before any root resources gets loaded.
This is not a final solution and should be considered when working on the architecture in general.

Related Issue

Motivation and Context

don't send unnecessary requests

How Has This Been Tested?

local installation with latest master of ocis

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Open tasks:

  • test it in staging environment

@fschade fschade added Type:Bug Something isn't working Early-Adopter:CERN labels Oct 10, 2021
@fschade fschade requested a review from kulmann October 10, 2021 12:57
@fschade fschade self-assigned this Oct 10, 2021
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersBlacklisted https://drone.owncloud.com/owncloud/web/19520/26/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19522/11/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/19522/9/1
The following scenarios passed on retry:

  • webUIDeleteFilesFolders/deleteFilesFolders.feature:59

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19522/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:36

@kulmann kulmann force-pushed the fix-personal-redirects branch from fb39ae2 to bdaef9f Compare October 13, 2021 15:10
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found a bug: when you're in the root folder of All files you don't get redirected to the homeFolder anymore when clicking on the All files menu item.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

38.5% 38.5% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19615/11/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/19615/12/1
The following scenarios passed on retry:

  • webUIFilesActionMenu/versions.feature:15

@fschade fschade merged commit e3cd448 into master Oct 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-personal-redirects branch October 13, 2021 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Early-Adopter:CERN Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to homeFolder only
3 participants