Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] feat: move expiration date to a drop #5806

Merged
merged 67 commits into from
Oct 15, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
a94bc5c
feat: move expiration date to a drop
LukasHirt Sep 14, 2021
6e3fd50
tests: add expiration date integration and unit tests
LukasHirt Sep 18, 2021
ace1fe8
chore: add expiration date tests set into drone
LukasHirt Sep 19, 2021
1cae420
feat: use new datepicker in public links
LukasHirt Sep 21, 2021
005901e
tests: fix E2E expiration date tests
LukasHirt Sep 21, 2021
0edadb2
tests: update snapshots
LukasHirt Sep 21, 2021
034f606
tests: fix unit expiration tests
LukasHirt Sep 21, 2021
5072b43
fix: add missing class to expiration date btn
LukasHirt Sep 21, 2021
908498d
tests: update snapshots
LukasHirt Sep 21, 2021
379404f
fix: use ISO format for expireDate
LukasHirt Sep 21, 2021
d79f3c0
fix: display already set expiration date
LukasHirt Sep 21, 2021
9045963
tests: update snapshots
LukasHirt Sep 22, 2021
7c2c292
tests: use fake timers
LukasHirt Sep 22, 2021
486f223
tests: fix unit tests
LukasHirt Sep 22, 2021
aeba58b
tests: do not select day outside of current month
LukasHirt Sep 23, 2021
a4dddc1
feat: add addDays helper
LukasHirt Sep 23, 2021
8cf16fc
tests: fix wrong expirationField reference
LukasHirt Sep 23, 2021
14ba8f8
feat: enforce expiration date in datepicker
LukasHirt Sep 23, 2021
832ac18
tests: adjust expiration date expected failures
LukasHirt Sep 23, 2021
dcb4e7d
tests: skip expiration date root test in oCIS
LukasHirt Sep 23, 2021
7e0207b
tests: remove redundant skipOnOCIS tag
LukasHirt Sep 23, 2021
e99ecd3
tests: specify locate strategy
LukasHirt Sep 23, 2021
5bd55c6
Bump ODS to 11.0.0-alpha, add changelogs
pascalwengerter Sep 28, 2021
a525766
Merge branch 'master' into feat/expiration-date-drop
lookacat Oct 4, 2021
f63c5a5
WIP fixing tests, upgrading ODS
lookacat Oct 4, 2021
05dcb38
fixed linting
lookacat Oct 5, 2021
b4f8774
removed snapshot that doesn't reflect the actual result
lookacat Oct 5, 2021
2ae5af1
Merge branch 'master' into feat/expiration-date-drop
lookacat Oct 5, 2021
961e4fb
fixed merge gone wrong
lookacat Oct 5, 2021
2c22f89
removed merge leftover
lookacat Oct 5, 2021
6cea063
cleanup notification test
fschade Oct 6, 2021
cb5a3a7
get rid of not needed test stubs
fschade Oct 6, 2021
630b906
WIP fix unittests
lookacat Oct 6, 2021
1568bc7
Merge branch 'feat/expiration-date-drop' of https://github.com/ownclo…
lookacat Oct 6, 2021
b42c077
WIP
lookacat Oct 6, 2021
8b97d9a
fixed messagebar test
lookacat Oct 7, 2021
cc41f20
Fixed QuickActions test
lookacat Oct 7, 2021
075350d
fixed last Unittest 🎉
lookacat Oct 7, 2021
0eddd52
Merge branch 'master' into feat/expiration-date-drop
lookacat Oct 7, 2021
5c5e705
fix broken tests and get rid of unnecessary warnings
fschade Oct 7, 2021
9d2304d
fixed integrations tests, only work isolated...
lookacat Oct 10, 2021
e8a6343
Merge branch 'feat/expiration-date-drop' of https://github.com/ownclo…
lookacat Oct 10, 2021
e7d5e5c
clear sessionstorage after each test and remove devLeftover
fschade Oct 11, 2021
8779653
rename test
lookacat Oct 11, 2021
3569996
Merge branch 'master' into feat/expiration-date-drop
lookacat Oct 11, 2021
6c64372
remove merging error
lookacat Oct 11, 2021
9a3a734
change locale test strategy for acceptance tests
lookacat Oct 11, 2021
9105172
remove locate strategy
lookacat Oct 12, 2021
801be25
Merge branch 'master' into feat/expiration-date-drop
lookacat Oct 12, 2021
284b863
Merge packages.json, yarn.lock
lookacat Oct 12, 2021
c0121b0
fix shareWithGroup
lookacat Oct 12, 2021
1e0f409
fixed sharingDialog xpath errors
lookacat Oct 12, 2021
e71e8ed
fixed linting
lookacat Oct 12, 2021
5ccb87f
remove unusefull test
lookacat Oct 13, 2021
f0f7ed3
Update changelog/unreleased/enhancement-update-ods
lookacat Oct 13, 2021
1cb6d9b
Update changelog/unreleased/enhancement-update-ods
lookacat Oct 13, 2021
7e51999
Update changelog/unreleased/enhancement-update-ods
lookacat Oct 13, 2021
7e28db5
remove code smell
lookacat Oct 13, 2021
3429878
Merge branch 'feat/expiration-date-drop' of https://github.com/ownclo…
lookacat Oct 13, 2021
5e93728
remove useless test
lookacat Oct 13, 2021
523d784
make public link expirationDate compatible with ocis and oc10
lookacat Oct 13, 2021
ab0ce84
update expected failures
lookacat Oct 13, 2021
1929218
Merge branch 'master' into feat/expiration-date-drop
lookacat Oct 13, 2021
0eb9e36
update yarn.lock
lookacat Oct 13, 2021
9b05093
"linting should be the last commit" and other lies I tell myself
lookacat Oct 13, 2021
093ec54
remove unused data-testid
lookacat Oct 14, 2021
e74e14c
fixed PR issues
lookacat Oct 14, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions .drone.star
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ config = {
"oC10Sharing1": [
"webUIRestrictSharing",
"webUISharingAutocompletion",
"webUISharingExpirationDate",
],
"webUIResharingToRoot": "oC10ResharingToRoot",
"oC10SharingFilePermission": [
Expand Down Expand Up @@ -103,10 +104,6 @@ config = {
"webUISharingInternalUsersShareWithPage",
],
"webUISharingInternalUsersBlacklisted": "oC10SharingInternalUsersBlacklisted",
"oC10SharingInternalUsersExpire": [
"webUISharingInternalUsersExpire",
"webUISharingInternalUsersExpireToRoot",
],
"oC10SharingInternalUsersSharingIndicator": [
"webUISharingInternalUsersSharingIndicator",
"webUISharingInternalUsersToRootSharingIndicator",
Expand Down Expand Up @@ -242,8 +239,7 @@ config = {
"webUISharingInternalUsersCollaborator",
"webUISharingInternalUsersShareWithPage",
"webUISharingInternalUsersBlacklisted",
"webUISharingInternalUsersExpire",
"webUISharingInternalUsersExpireToRoot",
"webUISharingExpirationDate",
"webUISharingInternalUsersSharingIndicator",
"webUISharingInternalUsersToRoot",
"webUISharingInternalUsersToRootCollaborator",
Expand Down Expand Up @@ -335,15 +331,14 @@ config = {
"webUISharingInternalGroupsToRootEdgeCases",
"webUISharingInternalGroupsToRootSharingIndicator",
"webUISharingInternalUsers",
"webUISharingInternalUsersExpire",
"webUISharingExpirationDate",
"webUISharingInternalUsersCollaborator",
"webUISharingInternalUsersShareWithPage",
"webUISharingInternalUsersSharingIndicator",
"webUISharingInternalUsersToRootCollaborator",
"webUISharingInternalUsersToRootPreviews",
"webUISharingInternalUsersToRootShareWithPage",
"webUISharingInternalUsersToRootSharingIndicator",
"webUISharingInternalUsersExpireToRoot",
"webUISharingInternalUsersToRoot",
"webUISharingInternalUsersToRootBlacklisted",
"webUISharingPermissionsUsers",
Expand Down Expand Up @@ -412,7 +407,7 @@ config = {
"oCISSharingInternalUsers1": [
"webUISharingInternalUsers",
"webUISharingAutocompletion",
"webUISharingInternalUsersExpire",
"webUISharingExpirationDate",
],
"oCISSharingInternalUsers2": [
"webUISharingInternalUsersBlacklisted",
Expand Down Expand Up @@ -538,15 +533,14 @@ config = {
"webUISharingInternalGroupsToRootEdgeCases",
"webUISharingInternalGroupsToRootSharingIndicator",
"webUISharingInternalUsers",
"webUISharingInternalUsersExpire",
"webUISharingExpirationDate",
"webUISharingInternalUsersCollaborator",
"webUISharingInternalUsersShareWithPage",
"webUISharingInternalUsersSharingIndicator",
"webUISharingInternalUsersToRootCollaborator",
"webUISharingInternalUsersToRootPreviews",
"webUISharingInternalUsersToRootShareWithPage",
"webUISharingInternalUsersToRootSharingIndicator",
"webUISharingInternalUsersExpireToRoot",
"webUISharingInternalUsersToRoot",
"webUISharingInternalUsersToRootBlacklisted",
"webUISharingPermissionsUsers",
Expand Down Expand Up @@ -591,7 +585,6 @@ rootSharingTestSuites = [
"webUISharingInternalGroupsToRoot",
"webUISharingInternalGroupsToRootEdgeCases",
"webUISharingInternalGroupsToRootSharingIndicator",
"webUISharingInternalUsersExpireToRoot",
"webUISharingInternalUsersToRoot",
"webUISharingInternalUsersToRootBlacklisted",
"webUISharingInternalUsersToRootCollaborator",
Expand Down Expand Up @@ -646,7 +639,7 @@ basicTestSuites = [
"webUISharingInternalUsers",
"webUISharingInternalUsersBlacklisted",
"webUISharingInternalUsersCollaborator",
"webUISharingInternalUsersExpire",
"webUISharingExpirationDate",
"webUISharingInternalUsersShareWithPage",
"webUISharingInternalUsersSharingIndicator",
"webUISharingPermissionsUsers",
Expand Down
3 changes: 3 additions & 0 deletions __fixtures__/recipients.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default {
users: [{ label: 'bob', value: { shareType: 0, shareWith: 'bob', userType: 0 } }]
}
61 changes: 60 additions & 1 deletion __mocks__/sdk.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import fixtureSharedViaLinksFiles from '../__fixtures__/sharedViaLinkFiles'
import fixtureSharedWithMeFiles from '../__fixtures__/sharedWithMeFiles'
import fixtureDeletedFiles from '../__fixtures__/deletedFiles'
import fixturePublicFiles from '../__fixtures__/publicFiles'
import fixtureRecipients from '../__fixtures__/recipients'

export default {
files: {
Expand Down Expand Up @@ -41,6 +42,64 @@ export default {
list: path => fixturePublicFiles[path]
},
shares: {
getShares: () => new Promise(resolve => resolve())
getShares: () => Promise.resolve(),
getRecipients,
shareFileWithUser: (path, id, params) =>
Promise.resolve({
shareInfo: {
id: 1,
share_type: 0,
uid_owner: 'alice', // TODO: get user dynamically
displayname_owner: 'alice', // TODO: get user dynamically
permissions: params.permissions,
stime: new Date().getTime(),
expiration: params.expirationDate,
uid_file_owner: 'alice', // TODO: get user dynamically
displayname_file_owner: 'alice', // TODO: get user dynamically
path,
item_type: 'folder', // TODO: get item type dynamically
item_source: 10,
file_source: 10,
file_parent: 6,
file_target: path,
share_with: id,
share_with_displayname: id
}
}),
shareFileWithGroup: () => Promise.resolve(),
updateShare: (id, params) => {
const share = {
shareInfo: {
id,
share_type: 0,
uid_owner: 'alice', // TODO: get user dynamically
displayname_owner: 'alice', // TODO: get user dynamically
permissions: params.permissions,
stime: new Date().getTime(),
uid_file_owner: 'alice', // TODO: get user dynamically
displayname_file_owner: 'alice', // TODO: get user dynamically
path: '/Documents', // TODO: get path dynamically
item_type: 'folder', // TODO: get item type dynamically
item_source: 10,
file_source: 10,
file_parent: 6,
file_target: '/Documents', // TODO: get path dynamically
share_with: 'bob', // TODO: get user dynamically
share_with_displayname: 'bob' // TODO: get user dynamically
}
}

if (params.expireDate) {
share.shareInfo.expiration = params.expireDate
}

return Promise.resolve(share)
}
}
}

function getRecipients(query) {
const users = fixtureRecipients.users.filter(user => user.label.includes(query))

return { exact: { users, groups: [], remotes: [] }, users: [], groups: [], remotes: [] }
}
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-datepicker-dropdown
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: Datepicker in Dropdown

We have moved the datepicker for share expiration in the right sidebar into
a dropdown to align it with the other elements when creating/editing shares.

https://github.com/owncloud/web/pull/5806
10 changes: 10 additions & 0 deletions changelog/unreleased/enhancement-update-ods
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Enhancement: Update ODS to v11.0.0

We updated the ownCloud Design System to version 11.0.0. Please refer to the full changelog in the ODS release (linked) for more details. Summary:

- Bugfix - Prevent hover style on footer of OcTableFiles: https://github.com/owncloud/owncloud-design-system/pull/1667
- Change - Replace vue-datetime with v-calendar in our datepicker component: https://github.com/owncloud/owncloud-design-system/pull/1661
- Enhancement - Allow hover option in OcTableFiles: https://github.com/owncloud/owncloud-design-system/pull/1632

https://github.com/owncloud/web/pull/5806
https://github.com/owncloud/owncloud-design-system/releases/tag/v11.0.0
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-typescript": "^8.2.5",
"@testing-library/jest-dom": "^5.13.0",
"@testing-library/user-event": "^13.2.1",
"@testing-library/vue": "^5.6.2",
"@types/cucumber": "^7.0.0",
"@types/jest": "^26.0.23",
Expand Down
Loading