[unit-tests-only] Implemented todo unit tests for route helper
#5795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiranparajuli589
requested review from
fschade,
kulmann and
pascalwengerter
as code owners
saw-jan
reviewed
Sep 14, 2021
kiranparajuli589
force-pushed
the
implement-test-todo-route-helper
branch
from
b83b89d to
d9863d0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
kiranparajuli589
force-pushed
the
implement-test-todo-route-helper
branch
from
d9863d0 to
f990d9d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
pascalwengerter
approved these changes
Nov 11, 2021
| it.todo('should return "false" if given route meta auth is "true"') | ||
| it.todo('should return "true" if given route meta auth is "false"') | ||
| it('should return "false" if given route has no meta information', () => { | ||
| expect(isPublicPage({ name: 'files-public-list' })).toBe(false) |
There was a problem hiding this comment.
files-public-list returns false when checked if it is a public page? 🤔 we need to check our code, it's not the test that is falsy I think
delete-merged-branch
bot
deleted the
implement-test-todo-route-helper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
todounit tests forroutehelperRelated Issue
Types of changes
Checklist: