Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests-only] Add TODO unit tests for publicLinkRolesDefinition helper #5779

Merged
merged 1 commit into from
Sep 8, 2021
Merged

[unit-tests-only] Add TODO unit tests for publicLinkRolesDefinition helper #5779

merged 1 commit into from
Sep 8, 2021

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Sep 6, 2021 •
edited
Loading

Description

  • added TODO unit tests for files package helper: publicLinkRolesDefinition.js

Related Issue

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan added the QA:team label Sep 6, 2021
@saw-jan saw-jan self-assigned this Sep 6, 2021
@saw-jan saw-jan mentioned this pull request Sep 6, 2021
Closed
53 tasks
kiranparajuli589
kiranparajuli589 reviewed Sep 8, 2021
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍🏼

@saw-jan saw-jan force-pushed the publicLinkRoles-helper-tests branch from 368de46 to 9bed1d1 Compare September 8, 2021 11:39
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 12cdbaa into master Sep 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the publicLinkRoles-helper-tests branch September 8, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @pascalwengerter @kiranparajuli589