Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests-only] Added unit tests todo items for resources helper #5774

Closed
wants to merge 1 commit into from
Closed

[unit-tests-only] Added unit tests todo items for resources helper #5774

wants to merge 1 commit into from

Conversation

kiranparajuli589
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@kiranparajuli589 kiranparajuli589 mentioned this pull request Sep 3, 2021
Closed
53 tasks
pascalwengerter
pascalwengerter reviewed Nov 11, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the ideal way here is. The helper is huge and only partly covered in the outlined test todo-s, but also we're thinking about refactoring this part soon. @kulmann @fschade @paulcod3 opinions?

packages/web-app-files/tests/unit/helpers/resources.spec.js
})

describe('aggregateResourceShares', () => {
// it.todo('')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kiranparajuli589 what's the idea here? :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But please don't invest further resources here until we as the web team knows what we want - see above

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would say skip it or test just the basics, the resources helpers is something we have to refactor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pascalwengerter @fschade sorry I forget to follow up on this PR, actually, this was a draft, I was still not finished and got involved with other things.

Are the added todos good for further implementations? or should we just close it and test only after the refactorings are done.

If it's not required for now, feel free to close it (or just ping me ;)).

@pascalwengerter pascalwengerter added Status:Blocked Status:Needs-Review Needs review from a maintainer Status:Needs-Revision Needs code input from a maintainer labels Nov 11, 2021
@kiranparajuli589
Copy link
Contributor Author

closed as it seems not required further

@phil-davis phil-davis deleted the test-todo-resources-helper branch February 2, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter left review comments

@fschade fschade fschade left review comments

Assignees
No one assigned
Labels
QA:team Status:Blocked Status:Needs-Review Needs review from a maintainer Status:Needs-Revision Needs code input from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiranparajuli589 @pascalwengerter @fschade