Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unit-tests-only] Added todo unit tests for statusIndicator helper #5771

Merged
merged 1 commit into from
Sep 9, 2021
Merged

[unit-tests-only] Added todo unit tests for statusIndicator helper #5771

merged 1 commit into from
Sep 9, 2021

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Sep 3, 2021 •
edited
Loading

Description

  • Added todo unit tests for statusIndicator helper from packages/web-app-files/helper
  • todo tests for only the exported function is added

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kiranparajuli589 kiranparajuli589 force-pushed the test-status-indicator-todo branch from 42db3b9 to 5a64740 Compare September 3, 2021 07:35
@kiranparajuli589 kiranparajuli589 self-assigned this Sep 3, 2021
@kiranparajuli589 kiranparajuli589 mentioned this pull request Sep 3, 2021
Closed
53 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pascalwengerter
pascalwengerter approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me & for now, would be nice to have the implementation close to https://github.com/owncloud/web/pull/5791/files

@pascalwengerter pascalwengerter merged commit d906439 into master Sep 9, 2021
@pascalwengerter pascalwengerter deleted the test-status-indicator-todo branch September 9, 2021 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiranparajuli589 @pascalwengerter @saw-jan