Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Bump commit id for oCIS #5667

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Aug 12, 2021

Description

oCIS PR owncloud/ocis#2385 has just been merged. It updates reva in oCIS.

Bump the commit id here in owncloud/web so that we test against that latest oCIS.

webUIUpload/upload.feature:99 was failing intermittently. I have tagged it @disablePreviews like other similar upload-overwrite scenarios.

Part of issue owncloud/QA#684

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

Results for oC10SharingPublicManagement https://drone.owncloud.com/owncloud/web/18239/34/1
The following scenarios passed on retry:

  • webUISharingPublicManagement/publicLinkIndicator.feature:27

@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18239/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@ownclouders
Copy link
Contributor

Results for oC10SharingExternal https://drone.owncloud.com/owncloud/web/18239/39/1
The following scenarios passed on retry:

  • webUISharingExternal/federationSharing.feature:363

@phil-davis
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/web/18239/12/14
runsh: Total unexpected failed scenarios throughout the test run:
webUIFilesActionMenu/versions.feature:36

  @files_versions-app-required @issue-ocis-1328
  Scenario: sharee can see the versions of a file
- Connecting to selenium on port 4444...

ℹ Connected to selenium on port 4444 (412ms).
  Using: chrome (92.0.4515.107) on Linux platform.

  tests/acceptance/features/webUIFilesActionMenu/versions.feature:36

    Given these users have been created with default attributes and without skeleton files:
      │ username │
      │ user0    │
      │ Alice    │
    Given user "user0" has uploaded file with content "lorem content" to "lorem-file.txt"
    And user "user0" has uploaded file with content "lorem" to "lorem-file.txt"
    And user "user0" has uploaded file with content "new lorem content" to "lorem-file.txt"
    And user "user0" has shared file "lorem-file.txt" with user "Alice"
    And user "Alice" has logged in using the webUI
√ Element <#user> was visible after 1287 milliseconds.
√ Element <#user> was not present after 15 milliseconds.
√ Element <button[type=submit]> was visible after 53 milliseconds.
√ Element <button[type=submit]> was not present after 40 milliseconds.
√ Element <.oc-app-container> was visible after 1428 milliseconds.
    When the user browses to display the "versions" details of file "lorem-file.txt"
√ Element <//span[contains(@class, "oc-resource-name") and (@data-test-resource-name='lorem-file.txt' or @data-test-resource-path='/lorem-file.txt')]/ancestor::tr[contains(@class, "oc-tbody-tr")]> was present after 24 milliseconds.
√ Element <.files-table .oc-tbody-tr> was present after 21 milliseconds.
√ Element <//div[contains(@id, "files-sidebar")]> was visible after 38 milliseconds.
waiting for 500ms ...
√ Element <#sidebar-panel-versions-item> was present after 20 milliseconds.
    Then the content of file "lorem-file.txt" for user "Alice" should be "new lorem content"
√ Passed [strictEqual]: Failed asserting remote file lorem-file.txt is same as content new lorem content for userAlice
    And the versions list should contain 2 entries
    ✖ failed
      AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
      
      1 !== 2
      
          + expected - actual
      
          -1
          +2
      
          at _callee20$ (/var/www/owncloud/web/tests/acceptance/stepDefinitions/filesContext.js:480:17)
          at tryCatch (/var/www/owncloud/web/node_modules/regenerator-runtime/runtime.js:63:40)
          at Generator.invoke [as _invoke] (/var/www/owncloud/web/node_modules/regenerator-runtime/runtime.js:293:22)
          at Generator.next (/var/www/owncloud/web/node_modules/regenerator-runtime/runtime.js:118:21)
          at asyncGeneratorStep (/var/www/owncloud/web/tests/acceptance/stepDefinitions/filesContext.js:93:103)
          at _next (/var/www/owncloud/web/tests/acceptance/stepDefinitions/filesContext.js:95:194)
          at runMicrotasks (<anonymous>)
          at processTicksAndRejections (node:internal/process/task_queues:96:5)

  Result: failed

That failed on oC10 - unexpected.

I will update again and see what CI thinks.

@phil-davis phil-davis force-pushed the bump-commit-id-20210812 branch from 7be7ecb to 3dbedd8 Compare August 12, 2021 16:25
@ownclouders
Copy link
Contributor

Results for oC10SharingExternalRoot https://drone.owncloud.com/owncloud/web/18252/40/1
The following scenarios passed on retry:

  • webUISharingExternalToRoot/federationSharing.feature:356

@phil-davis phil-davis force-pushed the bump-commit-id-20210812 branch from 3dbedd8 to 302ba95 Compare August 13, 2021 03:03
@phil-davis phil-davis force-pushed the bump-commit-id-20210812 branch from 302ba95 to 6ffc2c1 Compare August 13, 2021 03:13
@sonarcloud
Copy link

sonarcloud bot commented Aug 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 963556d into master Aug 13, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-commit-id-20210812 branch August 13, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants