Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Web-648: Details sidebar for multiple selection #5630

Merged
merged 61 commits into from
Aug 12, 2021
Merged
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
e419320
Add details sidebar for multiple selection
lookacat Aug 6, 2021
316ccaa
Merge branch 'master' into WEB-648-details-for-multiple-selection
lookacat Aug 6, 2021
d938d95
fixed merge issues
lookacat Aug 6, 2021
c4bfb74
fixed highlightedFile issue for now, udpated package version to RC
lookacat Aug 9, 2021
488072b
hide size if no size is to display
lookacat Aug 9, 2021
6b64efc
fixed linting
lookacat Aug 9, 2021
9de2462
addressed merge request issues
lookacat Aug 9, 2021
b1a545a
fixed linting
lookacat Aug 9, 2021
35d6ff6
removed old test
lookacat Aug 9, 2021
a824f19
make sidebar closable
lookacat Aug 9, 2021
ba3c3d4
fixed showSidebar
lookacat Aug 9, 2021
810628d
removed file-info for multiple select
lookacat Aug 10, 2021
f32627c
fixed visibility observer, moved sidebar toggle logic to parent compo…
lookacat Aug 10, 2021
28a2cb6
update yarn.lock
lookacat Aug 11, 2021
fcce1e2
Fix sidebar in trashbin for multi selection
kulmann Aug 11, 2021
96a03f1
Modify selection model on quick action click
kulmann Aug 11, 2021
3cf03bb
Remove setHighlightedFile from the store
kulmann Aug 11, 2021
64ffabf
Bump ODS to v9.0.1
kulmann Aug 11, 2021
42869bd
Make linter happy
kulmann Aug 11, 2021
f020783
Fix opening sidebar in tests after click behaviour changed
kulmann Aug 12, 2021
307393b
Fix tests creating new files or folders by clearing selection first
kulmann Aug 12, 2021
39ef79d
Make linter happy
kulmann Aug 12, 2021
dc784dd
Fix helper call to clearing file selection
kulmann Aug 12, 2021
6a4f0a9
fixed share indicators
lookacat Aug 12, 2021
d339085
fixed cancel button when testing move files
lookacat Aug 12, 2021
74a2168
fixed linting
lookacat Aug 12, 2021
9f60fdc
Add details sidebar for multiple selection
lookacat Aug 6, 2021
cfb12e3
fixed merge issues
lookacat Aug 6, 2021
8a44731
fixed highlightedFile issue for now, udpated package version to RC
lookacat Aug 9, 2021
e20328d
hide size if no size is to display
lookacat Aug 9, 2021
f9bc7e5
fixed linting
lookacat Aug 9, 2021
70bf3aa
addressed merge request issues
lookacat Aug 9, 2021
d93577d
fixed linting
lookacat Aug 9, 2021
8969d3d
removed old test
lookacat Aug 9, 2021
6ac4fdb
make sidebar closable
lookacat Aug 9, 2021
d0cafed
fixed showSidebar
lookacat Aug 9, 2021
1eeccb6
removed file-info for multiple select
lookacat Aug 10, 2021
ca1d29e
fixed visibility observer, moved sidebar toggle logic to parent compo…
lookacat Aug 10, 2021
9963357
update yarn.lock
lookacat Aug 11, 2021
bfce828
Fix sidebar in trashbin for multi selection
kulmann Aug 11, 2021
6e9f422
Modify selection model on quick action click
kulmann Aug 11, 2021
6b15281
Remove setHighlightedFile from the store
kulmann Aug 11, 2021
43f848e
Bump ODS to v9.0.1
kulmann Aug 11, 2021
c5e8f5c
Make linter happy
kulmann Aug 11, 2021
31bd716
Fix opening sidebar in tests after click behaviour changed
kulmann Aug 12, 2021
656f70a
Fix tests creating new files or folders by clearing selection first
kulmann Aug 12, 2021
d394fb6
Make linter happy
kulmann Aug 12, 2021
fc08738
Fix helper call to clearing file selection
kulmann Aug 12, 2021
2677cc2
fixed share indicators
lookacat Aug 12, 2021
005733b
fixed cancel button when testing move files
lookacat Aug 12, 2021
b8dc5b5
fixed linting
lookacat Aug 12, 2021
1a3014c
fix some async/await in tests
kulmann Aug 12, 2021
767ef78
Set shorter timeout in tests
kulmann Aug 12, 2021
d64cfb6
Revert async/await when closing sidebar
kulmann Aug 12, 2021
db6b40e
Merge branch 'WEB-648-details-for-multiple-selection' of https://gith…
lookacat Aug 12, 2021
2ececa0
Add one broken sharing test to expected failures
kulmann Aug 12, 2021
03fa469
Fix waiting in modals (tests)
kulmann Aug 12, 2021
251f6e5
Don't open sidebar on selection
kulmann Aug 12, 2021
6151377
Merge branch 'WEB-648-details-for-multiple-selection' of https://gith…
lookacat Aug 12, 2021
51113e7
fixed initial sidebar open
lookacat Aug 12, 2021
40b5ed8
Remove test from expected failures
kulmann Aug 12, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed old test
  • Loading branch information
lookacat committed Aug 9, 2021
commit 35d6ff634738aa76e025c90cfa3c6397d1573877
5 changes: 0 additions & 5 deletions packages/web-app-files/tests/unit/views/Favorites.spec.js
Original file line number Diff line number Diff line change
@@ -125,11 +125,6 @@ describe('Favorites component', () => {
'files-table-squashed'
)
})
it('sets the "highlighted" attribute with the correct file id', () => {
expect(wrapper.find(selectors.favoritesTable).attributes('highlighted')).toEqual(
'file-id-234'
)
})
})
describe('previews', () => {
it('displays previews when the "disablePreviews" config is disabled', () => {