-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] fix: load folder in media viewer #5585
Conversation
LukasHirt
commented
Jul 29, 2021
- fixes [media-viewer] Reloading does not work #5427
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just did some manual testing and while it works great most of the time, sometimes images don't load properly (esp. when circling through them via the <
and >
icons). Investigating now if that was the case before already
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3d95b94
to
1ba2586
Compare
What exactly breaks? Requested image is not loading? Other images are not loaded and you cannot navigate? I tried both this PR and master and works fine for me (oc10) 🤷 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤖
@LukasHirt sorry mate, I quickly checked whilst doing smoke testing, perhaps it had been a caching issue on my side or sth. With the latest fixes today it seems really good 👌🏽 👏🏽 |
This comment has been minimized.
This comment has been minimized.
SonarCloud Quality Gate failed. |
Force merged with randomly failing CI with same issue as on master. Not related to this PR. |