Polish details in right sidebar #5483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalwengerter
changed the title
kulmann
approved these changes
Jul 8, 2021
pascalwengerter
force-pushed
the
08072021_update-sidebar-details
branch
from
6fa12ff to
8f23607
Compare
pascalwengerter
force-pushed
the
08072021_update-sidebar-details
branch
from
8f23607 to
028bd04
Compare
|
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17184/49/1
|
kulmann
approved these changes
Jul 8, 2021
| @@ -1,14 +1,14 @@ | |||
| <template> | |||
| <div id="oc-file-details-sidebar"> | |||
| <oc-loader v-if="loading" /> | |||
| <div v-else> | |||
| <div v-if="!loading && hasContent"> | |||
There was a problem hiding this comment.
Suggested change
| <div v-if="!loading && hasContent"> | |
| <div v-else-if="hasContent"> |
There was a problem hiding this comment.
Adding this and bumping ODS to v8.0.0 once it's released, then re-running CI and will merge this once it's green!
|
Kudos, SonarCloud Quality Gate passed! |
|
Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17186/49/1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Details accordion needs some more polishing
Additional: Update codeowners, unify data-test(-)ids, remove dead code
Related Issue