Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add page size #5470

Merged
merged 6 commits into from
Jul 8, 2021
Merged

feat: add page size #5470

merged 6 commits into from
Jul 8, 2021

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jul 7, 2021

Description

Add page size to the view options so that the user can choose how many items he wants to see per page

Screenshots

image

image

TODO:

  • Update ODS after page size component is release
  • Finish tests
  • Add changelog
  • Add here screenshot and desc

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Jul 7, 2021
@LukasHirt LukasHirt self-assigned this Jul 7, 2021
@update-docs

This comment has been minimized.

@fschade
Copy link
Contributor

fschade commented Jul 7, 2021

@LukasHirt at the moment the select extends the body and forces the user to scroll if the select is opened. Is it possible that we use calculated option on this select?

@pascalwengerter
Copy link
Contributor

@LukasHirt @tbsbdr what do you think about adding it to the View options instead of putting it next to the pagination buttons? :)

Screenshot 2021-07-07 at 14 55 20

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 7, 2021

I would have expected the "items per page" option in proximity to the pagination. if possible, things that belong together should be next to each other. any reason why this option should not be next to the pagination on bottom of the page?

example ebay:
image

@pascalwengerter
Copy link
Contributor

I would have expected the "items per page" option in proximity to the pagination. if possible, things that belong together should be next to each other. any reason why this option should not be next to the pagination on bottom of the page?

example ebay:
image

Good point, however I'd expect users not to tinker with this too often and keep the UI "clean" and since it's a View-config it could go in the dropdown(?)

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 7, 2021

yep, maybe. put it in the view-options 👍

@tbsbdr
Copy link
Contributor

tbsbdr commented Jul 7, 2021

eh, but: could you align the text to the left, and options to the right? would tidy it up a bit
image

@kulmann
Copy link
Member

kulmann commented Jul 7, 2021

eh, but: could you align the text to the left, and options to the right? would tidy it up a bit
image

Fully agreeing with this. However, not that easy with the way our components are structured right now.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@ownclouders

This comment has been minimized.

@LukasHirt LukasHirt marked this pull request as ready for review July 8, 2021 13:09
@ownclouders

This comment has been minimized.

Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude! Awesome 👌

@ownclouders

This comment has been minimized.

@pascalwengerter pascalwengerter mentioned this pull request Jul 8, 2021
17 tasks
@ownclouders

This comment has been minimized.

@LukasHirt
Copy link
Collaborator Author

@kulmann Could we disable in sonarcloud the rule for wrapping ul or ol? Since we have the custom component for that it's a bit annoying seeing it all the time fail.

@kulmann
Copy link
Member

kulmann commented Jul 8, 2021

@kulmann Could we disable in sonarcloud the rule for wrapping ul or ol? Since we have the custom component for that it's a bit annoying seeing it all the time fail.

yes, will do 👍

@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

57.1% 57.1% Coverage
8.8% 8.8% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17199/49/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@pascalwengerter pascalwengerter merged commit f5c3e57 into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the feat/page-size branch July 8, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants