Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make view options button less prominent #5450

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 5, 2021

This PR makes the view options button less prominent by giving it a raw appearance, making the gap size of the button smaller and shrinking the width of the drop to the actually needed size.

Screenshot 2021-07-05 at 17 06 05

Screenshot 2021-07-05 at 17 06 12

@kulmann kulmann self-assigned this Jul 5, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17078/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there might be accessibility concerns regarding it not looking like a proper button though

@kulmann
Copy link
Member Author

kulmann commented Jul 6, 2021

LGTM, there might be accessibility concerns regarding it not looking like a proper button though

I did some further reading about this. Seems like the most important part is to use buttons and links in a semantically correct way. That's fulfilled. Then it's helpful if buttons look like buttons for example if someone has an anxiety disorder and feels more comfortable knowing that buttons always look like buttons. But sometimes you need to use e.g. buttons in a text flow (i.e. inline buttons). Those obviously can't look like buttons, otherwise they would rip the text apart. This use case here obviously is no inline text, so the argument is not applicable. But we want the button to be as inconspicuous as possible, which is somewhat destroyed by the hover effect of the outline button...

@kulmann kulmann merged commit 6a96e01 into master Jul 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the view-options-button branch July 6, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants