Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply CSP rules for onlyoffice and richdocuments #5420

Merged
merged 5 commits into from
Jul 8, 2021
Merged

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jun 30, 2021

Description

The iframe integrations of the documentserver coming from onlyoffice / richdocuments need certain CSP rules. With this PR we're extracting the respective documentserver domains from the two apps. We'll work on a generic solution when it becomes relevant.

Motivation and Context

Enable onlyoffice to build an integration of their documentserver into a web extension.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jun 30, 2021
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16962/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17003/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/17003/10/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIMarkdownEditor-markdownFile-feature-26.png

webUIMarkdownEditor-markdownFile-feature-26.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17009/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@kulmann kulmann requested a review from fschade as a code owner July 8, 2021 14:01
@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/17197/6/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@kulmann kulmann force-pushed the oc10-app-iframe-csp branch from edd7b50 to 47bd0e9 Compare July 8, 2021 15:20
@kulmann kulmann requested a review from pascalwengerter July 8, 2021 15:20
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐘

@ownclouders
Copy link
Contributor

Results for oC10SharingInternalGroupsSharingIndicator https://drone.owncloud.com/owncloud/web/17203/23/1
The following scenarios passed on retry:

  • webUISharingInternalGroupsSharingIndicator/shareWithGroups.feature:114

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17203/49/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@kulmann kulmann merged commit 237cab0 into master Jul 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the oc10-app-iframe-csp branch July 8, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants