Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Bump test commit ids #5359

Merged
merged 3 commits into from
Jun 24, 2021

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 24, 2021

Description

  1. Bump the commit ids for the servers used in tests. In particular, this will include [full-ci] update reva to v1.9 ocis#2210 reva 1.9.0 that was merged into OCIS.
  2. Fix storage name in expected-failures-with-ocis-server-ocis-storage.md like done in [full-ci] [tests-only] Bump core and web commit id ocis#2206
  3. Rationalize reporting of drone build link in GitHub comments - put the link to the drone CI pipeline directly after the top line of the comment "Results for..."

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Jun 24, 2021
@phil-davis phil-davis requested review from saw-jan and dpakach June 24, 2021 02:37
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

1 similar comment
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ownclouders
Copy link
Contributor

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/16803/34/1
The following scenarios passed on retry:

  • webUITrashbinRestore/trashbinRestore.feature:181

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/16803/47/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@phil-davis
Copy link
Contributor Author

Links on the above "passed on retry" comments look good.

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 653690e into master Jun 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the bump-test-commit-ids-20210624 branch June 24, 2021 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants