[full-ci] Add details accordion in sharing sidebar #5284

pascalwengerter · 2021-06-16T19:44:25Z

Description

Adds details panel to sharing sidebar, incl. preview img (if applicable)

Related Issue

Fixes "Details" in the Sidebar #5161

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

Code changes
Unit tests added
Acceptance tests added/modified

Open tasks:

Open issue

Links don't load correctly initially, need to visit "Links" sidebar panel to work (perhaps a store issue)

ownclouders · 2021-06-16T20:00:40Z

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

ownclouders · 2021-06-17T20:02:16Z

💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled...

pascalwengerter · 2021-06-24T13:16:21Z

Removed original content in this comment and put it in the PR description ☝🏽

kulmann

Some nitpicks incoming ;-) Also, in the shares section we're showing additionalInfo whenever present. Would be good to show that here in the details as well. There are ownCloud instances out there where the display name is not sufficient for being able to uniquely identify a user. In that case the server can be configured to return additionalInfo as well (which can be the username or the email address fwiw).

kulmann · 2021-07-05T12:58:54Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+          appearance="raw"
+          class="oc-mr-xs"
+          :aria-label="sharesLabel"
+          @click="expandPeoplesAccordion()"


You can spare 2 characters here, by just passing the callback ref.

Suggested change

@click="expandPeoplesAccordion()"

@click="expandPeoplesAccordion"

kulmann · 2021-07-05T12:59:05Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+          appearance="raw"
+          class="oc-mr-xs"
+          :aria-label="linksLabel"
+          @click="expandLinksAccordion()"


You can spare 2 characters here, by just passing the callback ref.

Suggested change

@click="expandLinksAccordion()"

@click="expandLinksAccordion"

kulmann · 2021-07-05T12:59:16Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+              v-oc-tooltip="seeVersionsLabel"
+              appearance="raw"
+              :aria-label="seeVersionsLabel"
+              @click="expandVersionsAccordion()"


You can spare 2 characters here, by just passing the callback ref.

Suggested change

@click="expandVersionsAccordion()"

@click="expandVersionsAccordion"

kulmann · 2021-07-05T12:59:29Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+              v-oc-tooltip="seeVersionsLabel"
+              appearance="raw"
+              :aria-label="seeVersionsLabel"
+              @click="expandVersionsAccordion()"


You can spare 2 characters here, by just passing the callback ref.

Suggested change

@click="expandVersionsAccordion()"

@click="expandVersionsAccordion"

kulmann · 2021-07-05T13:03:24Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+        <oc-img :src="highlightedFile.preview" alt="" />
+      </div>
+      <div
+        v-if="hasAnyShares && !isPublicPage"


I'm a big fan of not having too much logic in the template. Would be nice to have an additional showSharingInfo computed property which has an early return if (isPublicPage) { return false } and then checks for shares.

kulmann · 2021-07-05T13:07:08Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+    },
+    capitalizedModifiedDate() {
+      const lastModifiedDate = this.formDateFromNow(this.highlightedFile.mdate, 'Http')
+      return lastModifiedDate.charAt(0).toUpperCase() + lastModifiedDate.slice(1)


You can use lodash-es's upperFirst:

upperFirst(lastModifiedDate)

kulmann · 2021-07-05T13:10:24Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+    },
+    hasPeopleShares() {
+      return (
+        this.highlightedFile.shareTypes.includes(0) ||


Please use the shareTypes constants.

Also, checking for shareType 0 is not sufficient, is it? The people shares accordion shows other share types as well.

kulmann · 2021-07-05T13:10:31Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+    },
+    hasLinkShares() {
+      return (
+        this.highlightedFile.shareTypes.includes(3) ||


Please use the shareTypes constants.

kulmann · 2021-07-05T13:11:39Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+      )
+    },
+    isCurrentUser() {
+      return this.highlightedFile.ownerDisplayName === this.user.displayname


Please don't check the display name identifying the current user.

kulmann · 2021-07-05T13:13:25Z

packages/web-app-files/src/components/SideBar/Details/FileDetails.vue

+      )
+    },
+    detailsTableLabel() {
+      return this.$gettext('Overview on the information about the selected file')


Suggested change

return this.$gettext('Overview on the information about the selected file')

return this.$gettext('Overview of the information about the selected file')

ownclouders · 2021-07-05T16:28:13Z

Results for oCISSharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/17080/59/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

ownclouders · 2021-07-05T22:06:59Z

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17084/47/1
The following scenarios passed on retry:

webUIRestrictSharing/restrictSharing.feature:49

ownclouders · 2021-07-05T22:07:42Z

Results for oC10SharingInternalUsersRoot2 https://drone.owncloud.com/owncloud/web/17084/28/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalUsersToRootPreviews-shareWithUsers-feature-54.png

webUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-79.png

ownclouders · 2021-07-05T22:08:41Z

Results for oC10SharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/17084/33/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-248.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-93.png

ownclouders · 2021-07-05T22:10:19Z

Results for oC10SharingInternalGroups https://drone.owncloud.com/owncloud/web/17084/20/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalGroups-shareWithGroups-feature-100.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases-feature-41.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases-feature-42.png

ownclouders · 2021-07-05T22:11:27Z

Results for oC10SharingPublicBasic https://drone.owncloud.com/owncloud/web/17084/31/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit-feature-160.png

webUISharingPublicBasic-publicLinkPublicActions-feature-12.png

ownclouders · 2021-07-05T22:11:45Z

Results for oC10SharingInternalGroupsToRoot https://drone.owncloud.com/owncloud/web/17084/21/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalGroupsToRoot-shareWithGroups-feature-128.png

webUISharingInternalGroupsToRoot-shareWithGroups-feature-74.png

webUISharingInternalGroupsToRoot-shareWithGroups-feature-95.png

webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases-feature-36.png

webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases-feature-37.png

ownclouders · 2021-07-05T22:12:35Z

Results for oC10SharingInternalUsersRoot1 https://drone.owncloud.com/owncloud/web/17084/27/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalUsersToRoot-shareWithUsers-feature-256.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-271.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-53.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-70.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-99.png

ownclouders · 2021-07-05T22:12:41Z

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/17084/9/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders · 2021-07-05T22:13:55Z

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/17084/11/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-14.png

webUIFilesDetails-fileDetails-feature-25.png

webUIFilesDetails-fileDetails-feature-38.png

webUIFilesDetails-fileDetails-feature-51.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-99.png

webUIFilesList-fileList-feature-28.png

webUIFilesList-fileList-feature-33.png

webUIFilesSearch-search-feature-122.png

webUIFilesSearch-search-feature-175.png

ownclouders · 2021-07-05T22:14:40Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/17084/34/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUITrashbinDelete-trashbinDelete-feature-112.png

webUITrashbinDelete-trashbinDelete-feature-41.png

webUITrashbinFilesFolders-trashbinFilesFolders-feature-23.png

webUITrashbinFilesFolders-trashbinFilesFolders-feature-38.png

webUITrashbinFilesFolders-trashbinFilesFolders-feature-82.png

webUITrashbinFilesFolders-trashbinFilesFolders-feature-97.png

webUITrashbinRestore-trashbinRestore-feature-138.png

webUITrashbinRestore-trashbinRestore-feature-14.png

webUITrashbinRestore-trashbinRestore-feature-181.png

webUITrashbinRestore-trashbinRestore-feature-222.png

webUITrashbinRestore-trashbinRestore-feature-241.png

webUITrashbinRestore-trashbinRestore-feature-260.png

webUITrashbinRestore-trashbinRestore-feature-30.png

ownclouders · 2021-07-05T22:15:48Z

Results for oC10IntegrationApp2 https://drone.owncloud.com/owncloud/web/17084/63/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIMoveFilesFolders-moveFiles-feature-20.png

webUIMoveFilesFolders-moveFolders-feature-20.png

webUITrashbinFilesFolders-trashbinFilesFolders-feature-23.png

webUITrashbinRestore-trashbinRestore-feature-14.png

ownclouders · 2021-07-05T22:18:25Z

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/17084/23/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers-feature-108.png

webUISharingInternalUsers-shareWithUsers-feature-317.png

webUISharingInternalUsers-shareWithUsers-feature-337.png

webUISharingInternalUsers-shareWithUsers-feature-78.png

webUISharingInternalUsersShareWithPage-shareWithUsers-feature-92.png

ownclouders · 2021-07-05T22:18:45Z

Results for oC10CreateDelete https://drone.owncloud.com/owncloud/web/17084/7/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUICreateFilesFolders-createFile-feature-19.png

webUICreateFilesFolders-createFolders-feature-27.png

webUICreateFilesFolders-createFolders-feature-33.png

webUICreateFilesFolders-createFolders-feature-40.png

webUICreateFilesFolders-createFolders-feature-45.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-111.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-12.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-122.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-131.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-159.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-180.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-235.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-249.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-295.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-308.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-53.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-54.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-55.png

webUIDeleteFilesFolders-deleteFilesFolders-feature-56.png

ownclouders · 2021-07-07T10:10:42Z

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/17129/62/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks-feature-17.png

webUIPrivateLinks-accessingPrivateLinks-feature-9.png

ownclouders · 2021-07-07T10:12:09Z

Results for oC10SharingPublicBasic https://drone.owncloud.com/owncloud/web/17129/31/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit-feature-145.png

ownclouders · 2021-07-07T10:12:28Z

Results for oC10Files1 https://drone.owncloud.com/owncloud/web/17129/10/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIMarkdownEditor-markdownFile-feature-62.png

ownclouders · 2021-07-07T10:13:26Z

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/17129/23/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers-feature-126.png

ownclouders · 2021-07-07T10:14:26Z

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/17129/11/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-14.png

webUIFilesDetails-fileDetails-feature-25.png

webUIFilesDetails-fileDetails-feature-38.png

webUIFilesDetails-fileDetails-feature-51.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-99.png

ownclouders · 2021-07-07T10:32:06Z

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17131/47/1
The following scenarios passed on retry:

webUIRestrictSharing/restrictSharing.feature:49

ownclouders · 2021-07-07T10:32:59Z

Results for oC10SharingPublicExpireAndRoles https://drone.owncloud.com/owncloud/web/17131/33/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-134.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-248.png

ownclouders · 2021-07-07T10:34:55Z

Results for oC10SharingInternalUsersRoot1 https://drone.owncloud.com/owncloud/web/17131/27/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalUsersToRoot-shareWithUsers-feature-115.png

ownclouders · 2021-07-07T10:35:11Z

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/17131/11/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIFilesDetails-fileDetails-feature-107.png

webUIFilesDetails-fileDetails-feature-124.png

webUIFilesDetails-fileDetails-feature-74.png

webUIFilesDetails-fileDetails-feature-90.png

ownclouders · 2021-07-07T10:36:08Z

Results for oC10SharingPublicBasic https://drone.owncloud.com/owncloud/web/17131/31/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingPublicBasic-publicLinkEdit-feature-145.png

ownclouders · 2021-07-07T10:44:07Z

Results for oC10SharingInternalUsers https://drone.owncloud.com/owncloud/web/17131/23/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers-feature-126.png

ownclouders · 2021-07-07T11:17:50Z

Results for oC10Files2 https://drone.owncloud.com/owncloud/web/17133/11/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIFilesDetails-fileDetails-feature-107.png

webUIFilesDetails-fileDetails-feature-124.png

webUIFilesDetails-fileDetails-feature-74.png

webUIFilesDetails-fileDetails-feature-90.png

ownclouders · 2021-07-07T11:22:44Z

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17133/47/1
The following scenarios passed on retry:

webUIRestrictSharing/restrictSharing.feature:49

ownclouders · 2021-07-07T11:36:45Z

Results for oC10IntegrationNotifications https://drone.owncloud.com/owncloud/web/17134/61/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUISharingNotifications-notificationLink-feature-18.png

webUISharingNotifications-shareWithUsers-feature-21.png

webUISharingNotifications-shareWithUsers-feature-32.png

webUISharingNotifications-shareWithUsers-feature-40.png

webUISharingNotifications-shareWithUsers-feature-53.png

webUISharingNotificationsToRoot-notificationLink-feature-17.png

webUISharingNotificationsToRoot-shareWithUsers-feature-19.png

webUISharingNotificationsToRoot-shareWithUsers-feature-31.png

webUISharingNotificationsToRoot-shareWithUsers-feature-40.png

webUISharingNotificationsToRoot-shareWithUsers-feature-53.png

ownclouders · 2021-07-07T11:36:58Z

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17134/47/1
The following scenarios passed on retry:

webUIRestrictSharing/restrictSharing.feature:49

ownclouders · 2021-07-07T11:38:21Z

Results for oC10IntegrationApp1 https://drone.owncloud.com/owncloud/web/17134/62/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUIPrivateLinks-accessingPrivateLinks-feature-17.png

webUIPrivateLinks-accessingPrivateLinks-feature-9.png

ownclouders · 2021-07-07T12:01:34Z

Results for oC10Basic https://drone.owncloud.com/owncloud/web/17134/6/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUILogin-adminBlocksUser-feature-20.png

webUIPreview-imageMediaViewer-feature-141.png

webUIPreview-imageMediaViewer-feature-159.png

webUIPreview-imageMediaViewer-feature-84.png

webUIPreview-imageMediaViewer-feature-91.png

webUIPrivateLinks-accessingPrivateLinks-feature-17.png

webUIPrivateLinks-accessingPrivateLinks-feature-25.png

webUIPrivateLinks-accessingPrivateLinks-feature-9.png

webUIWebdavLockProtection-delete-feature-75.png

webUIWebdavLockProtection-delete-feature-76.png

webUIWebdavLockProtection-move-feature-123.png

webUIWebdavLockProtection-move-feature-124.png

webUIWebdavLockProtection-move-feature-145.png

webUIWebdavLockProtection-move-feature-146.png

webUIWebdavLockProtection-upload-feature-90.png

webUIWebdavLockProtection-upload-feature-91.png

sonarqubecloud · 2021-07-07T12:06:41Z

Please retry analysis of this Pull-Request directly on SonarCloud.

ownclouders · 2021-07-07T12:22:16Z

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17141/47/1
The following scenarios passed on retry:

webUIRestrictSharing/restrictSharing.feature:49

ownclouders · 2021-07-07T12:22:21Z

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17140/47/1
The following scenarios passed on retry:

webUIRestrictSharing/restrictSharing.feature:49

ownclouders · 2021-07-07T12:22:54Z

Results for oC10Trashbin https://drone.owncloud.com/owncloud/web/17140/34/1
The following scenarios passed on retry:

webUITrashbinRestore/trashbinRestore.feature:181

ownclouders · 2021-07-07T12:51:54Z

Results for oC10Basic https://drone.owncloud.com/owncloud/web/17140/6/1

💥 The acceptance tests failed. Please find the screenshots inside ...

webUILogin-adminBlocksUser-feature-20.png

webUIPreview-imageMediaViewer-feature-141.png

webUIPreview-imageMediaViewer-feature-159.png

webUIPreview-imageMediaViewer-feature-84.png

webUIPreview-imageMediaViewer-feature-91.png

webUIPrivateLinks-accessingPrivateLinks-feature-25.png

webUIWebdavLockProtection-delete-feature-75.png

webUIWebdavLockProtection-delete-feature-76.png

webUIWebdavLockProtection-move-feature-123.png

webUIWebdavLockProtection-move-feature-124.png

webUIWebdavLockProtection-move-feature-145.png

webUIWebdavLockProtection-move-feature-146.png

webUIWebdavLockProtection-upload-feature-90.png

webUIWebdavLockProtection-upload-feature-91.png

kulmann

LGTM 👍

pascalwengerter changed the title ~~Add draft for details in sharing sidebar~~ [WIP] Add draft for details in sharing sidebar Jun 16, 2021

pascalwengerter force-pushed the 16062021_details-in-sharing-sidebar branch 2 times, most recently from de1fccd to fe0cc16 Compare June 16, 2021 19:48

pascalwengerter force-pushed the 16062021_details-in-sharing-sidebar branch from fe0cc16 to 73a7a82 Compare June 17, 2021 19:39

pascalwengerter changed the title ~~[WIP] Add draft for details in sharing sidebar~~ Add draft for details in sharing sidebar Jun 21, 2021

pascalwengerter changed the title ~~Add draft for details in sharing sidebar~~ Add details accordion in sharing sidebar Jun 21, 2021

pascalwengerter force-pushed the 16062021_details-in-sharing-sidebar branch from 73a7a82 to bc71255 Compare June 24, 2021 13:09

pascalwengerter force-pushed the 16062021_details-in-sharing-sidebar branch 2 times, most recently from 394eb09 to 6cfa6b8 Compare July 5, 2021 12:52

kulmann suggested changes Jul 5, 2021

View reviewed changes

pascalwengerter changed the title ~~Add details accordion in sharing sidebar~~ [full-ci] Add details accordion in sharing sidebar Jul 5, 2021

pascalwengerter force-pushed the 16062021_details-in-sharing-sidebar branch 2 times, most recently from cf76dc2 to 9706e72 Compare July 5, 2021 21:45

kulmann and others added 3 commits July 7, 2021 12:48

Return bool from helper

bac6d7b

Only fetch versions in SidebarDetails on private routes

d78e461

update expected to fail file

ec77da4

kiranparajuli589 and others added 2 commits July 7, 2021 17:41

look for details panel for default

38b415e

update expected to fail file

125a387

kulmann approved these changes Jul 7, 2021

View reviewed changes

pascalwengerter merged commit 71e53e7 into master Jul 7, 2021

delete-merged-branch bot deleted the 16062021_details-in-sharing-sidebar branch July 7, 2021 14:13

	@click="expandPeoplesAccordion()"
	@click="expandPeoplesAccordion"

	@click="expandLinksAccordion()"
	@click="expandLinksAccordion"

	@click="expandVersionsAccordion()"
	@click="expandVersionsAccordion"

	return this.$gettext('Overview on the information about the selected file')
	return this.$gettext('Overview of the information about the selected file')

[full-ci] Add details accordion in sharing sidebar #5284

[full-ci] Add details accordion in sharing sidebar #5284

Conversation

pascalwengerter commented Jun 16, 2021 • edited Loading

Description

Related Issue

Types of changes

Checklist:

Open tasks:

Open issue

ownclouders commented Jun 16, 2021

ownclouders commented Jun 17, 2021

pascalwengerter commented Jun 24, 2021 • edited Loading

kulmann left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ownclouders commented Jul 5, 2021

ownclouders commented Jul 5, 2021

ownclouders commented Jul 5, 2021

webUISharingInternalUsersToRootPreviews-shareWithUsers-feature-54.png

webUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-79.png

ownclouders commented Jul 5, 2021

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-114.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-248.png

webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-93.png

ownclouders commented Jul 5, 2021

webUISharingInternalGroups-shareWithGroups-feature-100.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases-feature-41.png

webUISharingInternalGroupsEdgeCases-shareWithGroupsEdgeCases-feature-42.png

ownclouders commented Jul 5, 2021

webUISharingPublicBasic-publicLinkEdit-feature-160.png

webUISharingPublicBasic-publicLinkPublicActions-feature-12.png

ownclouders commented Jul 5, 2021

webUISharingInternalGroupsToRoot-shareWithGroups-feature-128.png

webUISharingInternalGroupsToRoot-shareWithGroups-feature-74.png

webUISharingInternalGroupsToRoot-shareWithGroups-feature-95.png

webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases-feature-36.png

webUISharingInternalGroupsToRootEdgeCases-shareWithGroupsEdgeCases-feature-37.png

ownclouders commented Jul 5, 2021

webUISharingInternalUsersToRoot-shareWithUsers-feature-256.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-271.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-53.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-70.png

webUISharingInternalUsersToRoot-shareWithUsers-feature-99.png

ownclouders commented Jul 5, 2021

webUISharingAcceptSharesToRoot-acceptShares-feature-110.png

webUISharingAcceptSharesToRoot-acceptShares-feature-131.png

webUISharingAcceptSharesToRoot-acceptShares-feature-143.png

webUISharingAcceptSharesToRoot-acceptShares-feature-158.png

webUISharingAcceptSharesToRoot-acceptShares-feature-31.png

webUISharingAcceptSharesToRoot-acceptShares-feature-315.png

webUISharingAcceptSharesToRoot-acceptShares-feature-357.png

webUISharingAcceptSharesToRoot-acceptShares-feature-50.png

webUISharingAcceptSharesToRoot-acceptShares-feature-90.png

ownclouders commented Jul 5, 2021

webUIFilesDetails-fileDetails-feature-116.png

webUIFilesDetails-fileDetails-feature-14.png

webUIFilesDetails-fileDetails-feature-25.png

webUIFilesDetails-fileDetails-feature-38.png

webUIFilesDetails-fileDetails-feature-51.png

webUIFilesDetails-fileDetails-feature-66.png

webUIFilesDetails-fileDetails-feature-82.png

webUIFilesDetails-fileDetails-feature-99.png

webUIFilesList-fileList-feature-28.png

webUIFilesList-fileList-feature-33.png

webUIFilesSearch-search-feature-122.png

webUIFilesSearch-search-feature-175.png

ownclouders commented Jul 5, 2021

webUITrashbinDelete-trashbinDelete-feature-112.png

webUITrashbinDelete-trashbinDelete-feature-41.png

pascalwengerter commented Jun 16, 2021 •

edited

Loading

pascalwengerter commented Jun 24, 2021 •

edited

Loading