Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable capability-based avatar img loading #5178

Merged
merged 1 commit into from
Jul 19, 2021
Merged

Enable capability-based avatar img loading #5178

merged 1 commit into from
Jul 19, 2021

Conversation

pascalwengerter
Copy link
Contributor

@pascalwengerter pascalwengerter commented May 31, 2021 •
edited
Loading

Can only be used with oCIS >= v1.6.0 and OC10 >= 10.7 (otherwise avatar imgs won't load)

Description

See changelog item

Related Issue

@kulmann kulmann mentioned this pull request Jun 18, 2021
Closed
This was referenced Jun 18, 2021
Closed
Closed
Closed
@labkode labkode mentioned this pull request Jun 22, 2021
Closed
@pascalwengerter pascalwengerter force-pushed the 31052021_check-avatar-capabilities branch from dccce3e to 485ab28 Compare July 8, 2021 14:23
@pascalwengerter pascalwengerter requested a review from fschade as a code owner July 8, 2021 14:23
@pascalwengerter pascalwengerter requested a review from kulmann July 8, 2021 14:24
@pascalwengerter pascalwengerter changed the title [Wait for OC10.8] Enable capability-based avatar img loading Enable capability-based avatar img loading Jul 8, 2021
@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17200/49/1
The following scenarios passed on retry:

  • webUIRestrictSharing/restrictSharing.feature:49

@ownclouders
Copy link
Contributor

Results for oCISFiles1 https://drone.owncloud.com/owncloud/web/17200/51/1

💥 Visual regression tests failed. Please find the screenshots inside ...

Diff Image:

topBar.png
Actual Image:

topBar.png
Comparing Against:

topBar.png

💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor Author

Failes in the VRT even though the capability is in the core master https://github.com/owncloud/core/search?q=profile_picture and it works locally when running against one of the beta Docker images

@pascalwengerter pascalwengerter force-pushed the 31052021_check-avatar-capabilities branch from 485ab28 to cbf800d Compare July 19, 2021 11:46
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oCISSharingBasic https://drone.owncloud.com/owncloud/web/17524/49/1
The following scenarios passed on retry:

  • webUISharingAcceptShares/acceptShares.feature:93

kulmann
kulmann approved these changes Jul 19, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🖼️

@pascalwengerter pascalwengerter merged commit 21a8cea into master Jul 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the 31052021_check-avatar-capabilities branch July 19, 2021 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
Early-Adopter:CERN Type:Technical-Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable avatar requests
3 participants
@pascalwengerter @ownclouders @kulmann