Focus breadcrumb on route change #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
requested changes
May 28, 2021
There was a problem hiding this comment.
Found one issue that I didn't think about before. This now steals the focus away from the nav directly after clicking in the left sidebar. As far as I understand this behaviour is only supposed to happen upon navigating within the file list or through the breadcrumbs.
pascalwengerter
force-pushed
the
28052021_focus-and-announce-breadcrumbs
branch
from
df03cdc to
831752a
Compare
Tried preventing it with what we discussed, checking if we're staying within the same route and only setting the focus on the last breadcrumb item if that's the case |
pascalwengerter
force-pushed
the
28052021_focus-and-announce-breadcrumbs
branch
from
831752a to
a833900
Compare
pascalwengerter
force-pushed
the
a11y-swarming
branch
from
60f33d6 to
80afe21
Compare
pascalwengerter
force-pushed
the
28052021_focus-and-announce-breadcrumbs
branch
from
a833900 to
365f650
Compare
kulmann
requested changes
May 31, 2021
pascalwengerter
force-pushed
the
28052021_focus-and-announce-breadcrumbs
branch
from
365f650 to
dcbf119
Compare
delete-merged-branch
bot
deleted the
28052021_focus-and-announce-breadcrumbs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Focus current active breadcrumb on route change and announce contents of current folder to screenreader