Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transalte fileActions opener #5121

Merged
merged 1 commit into from
May 18, 2021
Merged

Transalte fileActions opener #5121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelog/unreleased/enhancement-files-sidebar-shares
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ We've did several improvements to enhance the accessibility on the files sidebar
- Added aria-label for share receiver section
- Worked on unifying the way we handle translations: Focus on v-translate and $gettext()
- Turn tags into `<ul> & <li>` list, add aria-labelledby to both tag list and resharer tag list
- Translated "Open with $appName" for sidebar quick actions

https://github.com/owncloud/web/pull/5034
https://github.com/owncloud/web/pull/5043
https://github.com/owncloud/web/pull/5121
9 changes: 7 additions & 2 deletions packages/web-app-files/src/mixins/fileActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,13 @@ export default {
$_fileActions_editorActions() {
return this.apps.fileEditors.map(editor => {
return {
label: () => {
return `Open in ${this.apps.meta[editor.app].name}`
ariaLabel: () => {
const translated = this.$gettext('Open in %{app}')
return this.$gettextInterpolate(
translated,
{ app: this.apps.meta[editor.app].name },
true
)
},
icon: this.apps.meta[editor.app].icon,
handler: item => this.$_fileActions_openEditor(editor, item.path, item.id),
Expand Down