-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use slots in sidebar #5105
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
💥 Acceptance tests webUINotificationBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUINotifications-displayNotificationsOnWebUI-feature-18.png |
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUITrashbinDelete-trashbinDelete-feature-113.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinDelete-trashbinDelete-feature-42.png |
💥 Acceptance tests SharingInternalUsersExpireToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingInternalUsersExpireToRoot-shareWithUsersExpiringShares-feature-232.png |
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIMarkdownEditor-markdownFile-feature-62.pngwebUIMarkdownEditor-markdownFile-feature-63.png |
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-38.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-82.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-97.png |
💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingInternalUsersExpire-shareWithUsersExpiringShares-feature-240.png |
💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-106.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-11.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-147.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-24.pngwebUISharingPublicExpire-shareByPublicLinkExpiringLinks-feature-86.png |
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-93.png |
💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingPublicManagement-publicLinkIndicator-feature-110.pngwebUISharingPublicManagement-shareByPublicLink-feature-102.pngwebUISharingPublicManagement-shareByPublicLink-feature-12.pngwebUISharingPublicManagement-shareByPublicLink-feature-146.pngwebUISharingPublicManagement-shareByPublicLink-feature-201.pngwebUISharingPublicManagement-shareByPublicLink-feature-64.pngwebUISharingPublicManagement-shareByPublicLink-feature-90.png |
💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUITrashbinRestore-trashbinRestore-feature-138.pngwebUITrashbinRestore-trashbinRestore-feature-14.pngwebUITrashbinRestore-trashbinRestore-feature-181.pngwebUITrashbinRestore-trashbinRestore-feature-222.pngwebUITrashbinRestore-trashbinRestore-feature-241.pngwebUITrashbinRestore-trashbinRestore-feature-260.pngwebUITrashbinRestore-trashbinRestore-feature-30.png |
💥 Acceptance tests Upload failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIUpload-upload-feature-130.pngwebUIUpload-upload-feature-151.pngwebUIUpload-upload-feature-89.pngwebUIUpload-upload-feature-98.pngwebUIUpload-uploadEdgecases-feature-109.png |
💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-109.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-26.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-52.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-61.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-70.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-79.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-96.png |
💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingInternalUsersToRoot-shareWithUsers-feature-103.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-275.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-57.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-74.png |
💥 Acceptance tests ResharingToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIResharingToRoot-reshareUsers-feature-227.png |
💥 Acceptance tests Favorites failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIFavorites-favoritesFile-feature-110.pngwebUIFavorites-favoritesFile-feature-131.pngwebUIFavorites-favoritesFile-feature-14.pngwebUIFavorites-favoritesFile-feature-30.pngwebUIFavorites-favoritesFile-feature-65.pngwebUIFavorites-favoritesFile-feature-74.pngwebUIFavorites-favoritesFile-feature-80.pngwebUIFavorites-favoritesFile-feature-85.pngwebUIFavorites-unfavoriteFile-feature-104.pngwebUIFavorites-unfavoriteFile-feature-13.pngwebUIFavorites-unfavoriteFile-feature-34.pngwebUIFavorites-unfavoriteFile-feature-55.pngwebUIFavorites-unfavoriteFile-feature-72.png |
💥 Acceptance tests oc10-integration-notifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingNotifications-shareWithUsers-feature-21.pngwebUISharingNotifications-shareWithUsers-feature-32.pngwebUISharingNotifications-shareWithUsers-feature-40.pngwebUISharingNotifications-shareWithUsers-feature-53.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-19.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-31.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-40.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-53.png |
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingInternalGroups-shareWithGroups-feature-100.pngwebUISharingInternalGroups-shareWithGroups-feature-260.pngwebUISharingInternalGroups-shareWithGroups-feature-72.pngwebUISharingInternalGroups-shareWithGroups-feature-73.pngwebUISharingInternalGroups-shareWithGroups-feature-74.png |
💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingInternalGroupsToRoot-shareWithGroups-feature-128.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-234.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-69.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-70.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-71.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-74.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-95.png |
💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIDeleteFilesFolders-deleteFilesFolders-feature-111.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-12.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-122.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-159.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-180.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-235.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-249.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-295.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-308.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-53.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-54.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-55.pngwebUIDeleteFilesFolders-deleteFilesFolders-feature-56.png |
💥 Acceptance tests webUIResharing failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIResharing1-reshareUsers-feature-230.png |
💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUISharingNotifications-shareWithGroups-feature-24.pngwebUISharingNotifications-shareWithUsers-feature-21.pngwebUISharingNotifications-shareWithUsers-feature-32.pngwebUISharingNotifications-shareWithUsers-feature-40.pngwebUISharingNotifications-shareWithUsers-feature-53.pngwebUISharingNotificationsToRoot-shareWithGroups-feature-24.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-19.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-31.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-40.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-53.png |
💥 Visual regression tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIFilesDetails-fileDetails-feature-134.pngwebUIFilesDetails-fileDetails-feature-138.pngwebUIFilesList-fileList-feature-15.pngwebUIFilesList-fileList-feature-46.pngwebUIFilesList-sort-feature-51.pngwebUIFilesList-sort-feature-72.pngwebUIFilesSearch-search-feature-122.pngwebUIFilesSearch-search-feature-175.png |
💥 Acceptance tests IntegrationApp2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIMoveFilesFolders-moveFiles-feature-20.pngwebUIMoveFilesFolders-moveFolders-feature-20.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinRestore-trashbinRestore-feature-14.pngwebUIUpload-upload-feature-89.pngwebUIUpload-upload-feature-98.png |
💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIDeleteFilesFolders-deleteFilesFolders-feature-12.pngwebUIFavorites-favoritesFile-feature-14.pngwebUIFavorites-unfavoriteFile-feature-13.pngwebUIFavorites-unfavoriteFile-feature-55.pngwebUIFilesCopy-copy-feature-10.pngwebUIRenameFiles-renameFiles-feature-22.pngwebUIRenameFiles-renameFiles-feature-23.pngwebUIRenameFiles-renameFiles-feature-24.pngwebUIRenameFiles-renameFiles-feature-25.pngwebUIRenameFiles-renameFiles-feature-26.pngwebUIRenameFiles-renameFiles-feature-43.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-50.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-72.png |
💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUIFiles-download-feature-11.pngwebUIFiles-download-feature-24.pngwebUIFilesActionMenu-versions-feature-14.pngwebUIFilesCopy-copy-feature-10.pngwebUIFilesCopy-copy-feature-108.pngwebUIFilesCopy-copy-feature-116.pngwebUIFilesCopy-copy-feature-127.pngwebUIFilesCopy-copy-feature-26.pngwebUIFilesCopy-copy-feature-68.pngwebUIFilesCopy-copy-feature-69.pngwebUIFilesCopy-copy-feature-70.pngwebUIFilesCopy-copy-feature-71.pngwebUIFilesCopy-copy-feature-74.pngwebUIFilesCopy-copy-feature-87.pngwebUIFilesCopy-copy-feature-98.png |
💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15454/
webUILogin-adminBlocksUser-feature-20.pngwebUIPreview-imageMediaViewer-feature-13.pngwebUIPreview-imageMediaViewer-feature-131.pngwebUIPreview-imageMediaViewer-feature-14.pngwebUIPreview-imageMediaViewer-feature-140.pngwebUIPreview-imageMediaViewer-feature-149.pngwebUIPreview-imageMediaViewer-feature-15.pngwebUIPreview-imageMediaViewer-feature-158.pngwebUIPreview-imageMediaViewer-feature-17.pngwebUIPreview-imageMediaViewer-feature-24.pngwebUIPreview-imageMediaViewer-feature-34.pngwebUIPreview-imageMediaViewer-feature-55.pngwebUIPreview-imageMediaViewer-feature-56.pngwebUIPreview-imageMediaViewer-feature-59.pngwebUIPreview-imageMediaViewer-feature-67.pngwebUIPreview-imageMediaViewer-feature-83.pngwebUIPreview-imageMediaViewer-feature-90.png |
💥 Acceptance tests SharingAutocompletion failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingAutocompletion-shareAutocompletion-feature-115.pngwebUISharingAutocompletion-shareAutocompletion-feature-128.pngwebUISharingAutocompletion-shareAutocompletion-feature-141.pngwebUISharingAutocompletion-shareAutocompletion-feature-154.pngwebUISharingAutocompletion-shareAutocompletion-feature-168.pngwebUISharingAutocompletion-shareAutocompletion-feature-32.pngwebUISharingAutocompletion-shareAutocompletion-feature-44.pngwebUISharingAutocompletion-shareAutocompletion-feature-56.pngwebUISharingAutocompletion-shareAutocompletion-feature-66.pngwebUISharingAutocompletion-shareAutocompletion-feature-76.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-36.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-37.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-38.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-39.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-55.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-56.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-57.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-73.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-74.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-75.pngwebUISharingAutocompletion-shareAutocompletionSpecialChars-feature-76.png |
💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingAcceptShares-acceptShares-feature-100.pngwebUISharingAcceptShares-acceptShares-feature-116.pngwebUISharingAcceptShares-acceptShares-feature-135.pngwebUISharingAcceptShares-acceptShares-feature-16.pngwebUISharingAcceptShares-acceptShares-feature-203.pngwebUISharingAcceptShares-acceptShares-feature-218.pngwebUISharingAcceptShares-acceptShares-feature-235.pngwebUISharingAcceptShares-acceptShares-feature-78.pngwebUISharingAcceptShares-acceptShares-feature-89.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-110.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-131.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-143.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-15.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-158.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-235.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-245.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-255.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-267.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-282.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-299.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-31.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-315.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-357.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-366.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-379.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-397.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-50.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-72.pngwebUISharingAcceptSharesToRoot-acceptShares-feature-90.png |
💥 Acceptance tests IntegrationApp2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUIMoveFilesFolders-moveFiles-feature-20.pngwebUIMoveFilesFolders-moveFolders-feature-20.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinRestore-trashbinRestore-feature-14.pngwebUIUpload-upload-feature-98.png |
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUITrashbinDelete-trashbinDelete-feature-113.pngwebUITrashbinDelete-trashbinDelete-feature-29.pngwebUITrashbinDelete-trashbinDelete-feature-42.png |
💥 Acceptance tests SharingPermissionsUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingPermissionsUsers-sharePermissionsUsers-feature-100.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-101.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-102.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-103.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-104.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-122.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-123.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-126.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-156.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-157.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-158.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-161.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-179.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-197.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-210.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-22.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-224.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-37.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-53.pngwebUISharingPermissionsUsers-sharePermissionsUsers-feature-69.png |
💥 Acceptance tests SharingInternalUsersExpire failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingInternalUsersExpire-shareWithUsersExpiringShares-feature-240.png |
💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUITrashbinRestore-trashbinRestore-feature-138.pngwebUITrashbinRestore-trashbinRestore-feature-14.pngwebUITrashbinRestore-trashbinRestore-feature-181.pngwebUITrashbinRestore-trashbinRestore-feature-222.pngwebUITrashbinRestore-trashbinRestore-feature-241.pngwebUITrashbinRestore-trashbinRestore-feature-260.pngwebUITrashbinRestore-trashbinRestore-feature-30.png |
💥 Acceptance tests webUIResharing failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUIResharing1-reshareUsers-feature-107.pngwebUIResharing1-reshareUsers-feature-115.pngwebUIResharing1-reshareUsers-feature-124.pngwebUIResharing1-reshareUsers-feature-134.pngwebUIResharing1-reshareUsers-feature-145.pngwebUIResharing1-reshareUsers-feature-166.pngwebUIResharing1-reshareUsers-feature-18.pngwebUIResharing1-reshareUsers-feature-187.pngwebUIResharing1-reshareUsers-feature-198.pngwebUIResharing1-reshareUsers-feature-214.pngwebUIResharing1-reshareUsers-feature-230.pngwebUIResharing1-reshareUsers-feature-248.pngwebUIResharing1-reshareUsers-feature-260.pngwebUIResharing1-reshareUsers-feature-74.pngwebUIResharing2-reshareUsers-feature-130.pngwebUIResharing2-reshareUsers-feature-131.pngwebUIResharing2-reshareUsers-feature-132.pngwebUIResharing2-reshareUsers-feature-133.pngwebUIResharing2-reshareUsers-feature-134.pngwebUIResharing2-reshareUsers-feature-18.pngwebUIResharing2-reshareUsers-feature-29.pngwebUIResharing2-reshareUsers-feature-41.pngwebUIResharing2-reshareUsers-feature-69.pngwebUIResharing2-reshareUsers-feature-70.pngwebUIResharing2-reshareUsers-feature-71.pngwebUIResharing2-reshareUsers-feature-72.pngwebUIResharing2-reshareUsers-feature-73.png |
💥 Acceptance tests webUISharingNotifications failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingNotifications-shareWithGroups-feature-24.pngwebUISharingNotifications-shareWithUsers-feature-21.pngwebUISharingNotifications-shareWithUsers-feature-32.pngwebUISharingNotifications-shareWithUsers-feature-40.pngwebUISharingNotifications-shareWithUsers-feature-53.pngwebUISharingNotificationsToRoot-shareWithGroups-feature-24.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-19.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-31.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-40.pngwebUISharingNotificationsToRoot-shareWithUsers-feature-53.png |
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-114.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-134.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-149.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-157.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-167.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-177.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-189.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-197.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-207.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-217.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-229.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-258.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-267.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-279.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-289.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-309.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-33.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-335.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-34.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-343.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-35.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-352.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-361.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-370.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-60.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-93.png |
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUIMoveFilesFolders-moveFiles-feature-105.pngwebUIMoveFilesFolders-moveFiles-feature-115.pngwebUIMoveFilesFolders-moveFiles-feature-12.pngwebUIMoveFilesFolders-moveFiles-feature-140.pngwebUIMoveFilesFolders-moveFiles-feature-20.pngwebUIMoveFilesFolders-moveFiles-feature-43.pngwebUIMoveFilesFolders-moveFiles-feature-51.pngwebUIMoveFilesFolders-moveFiles-feature-79.pngwebUIMoveFilesFolders-moveFiles-feature-81.pngwebUIMoveFilesFolders-moveFiles-feature-82.pngwebUIMoveFilesFolders-moveFiles-feature-85.pngwebUIMoveFilesFolders-moveFiles-feature-97.pngwebUIMoveFilesFolders-moveFolders-feature-12.pngwebUIMoveFilesFolders-moveFolders-feature-20.pngwebUIMoveFilesFolders-moveFolders-feature-33.pngwebUIMoveFilesFolders-moveFolders-feature-41.pngwebUIMoveFilesFolders-moveFolders-feature-66.pngwebUIMoveFilesFolders-moveFolders-feature-68.pngwebUIMoveFilesFolders-moveFolders-feature-69.pngwebUIMoveFilesFolders-moveFolders-feature-72.pngwebUIMoveFilesFolders-moveFolders-feature-81.pngwebUIMoveFilesFolders-moveFolders-feature-88.png |
💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-109.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-26.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-52.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-61.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-70.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-79.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-96.png |
💥 Acceptance tests webUINotificationBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUINotifications-displayNotificationsOnWebUI-feature-18.png |
💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingInternalUsers-shareWithUsers-feature-112.pngwebUISharingInternalUsers-shareWithUsers-feature-341.pngwebUISharingInternalUsers-shareWithUsers-feature-82.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-119.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-199.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-31.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-60.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-70.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-81.pngwebUISharingInternalUsersShareWithPage-shareWithUsers-feature-92.png |
💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingPublicManagement-publicLinkIndicator-feature-110.pngwebUISharingPublicManagement-publicLinkIndicator-feature-12.pngwebUISharingPublicManagement-publicLinkIndicator-feature-27.pngwebUISharingPublicManagement-publicLinkIndicator-feature-37.pngwebUISharingPublicManagement-publicLinkIndicator-feature-47.pngwebUISharingPublicManagement-publicLinkIndicator-feature-64.pngwebUISharingPublicManagement-publicLinkIndicator-feature-81.pngwebUISharingPublicManagement-publicLinkIndicator-feature-98.pngwebUISharingPublicManagement-shareByPublicLink-feature-102.pngwebUISharingPublicManagement-shareByPublicLink-feature-12.pngwebUISharingPublicManagement-shareByPublicLink-feature-120.pngwebUISharingPublicManagement-shareByPublicLink-feature-131.pngwebUISharingPublicManagement-shareByPublicLink-feature-146.pngwebUISharingPublicManagement-shareByPublicLink-feature-164.pngwebUISharingPublicManagement-shareByPublicLink-feature-171.pngwebUISharingPublicManagement-shareByPublicLink-feature-19.pngwebUISharingPublicManagement-shareByPublicLink-feature-201.pngwebUISharingPublicManagement-shareByPublicLink-feature-25.pngwebUISharingPublicManagement-shareByPublicLink-feature-64.pngwebUISharingPublicManagement-shareByPublicLink-feature-90.pngwebUISharingPublicManagement-sharingPublicSession-feature-10.pngwebUISharingPublicManagement-sharingPublicSession-feature-20.pngwebUISharingPublicManagement-sharingPublicSession-feature-31.pngwebUISharingPublicManagement-sharingPublicSession-feature-41.pngwebUISharingPublicManagement-sharingPublicSession-feature-54.png |
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUITrashbinFilesFolders-trashbinFilesFolders-feature-23.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-38.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-82.pngwebUITrashbinFilesFolders-trashbinFilesFolders-feature-97.png |
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingInternalGroups-shareWithGroups-feature-100.pngwebUISharingInternalGroups-shareWithGroups-feature-260.pngwebUISharingInternalGroups-shareWithGroups-feature-72.pngwebUISharingInternalGroups-shareWithGroups-feature-73.pngwebUISharingInternalGroups-shareWithGroups-feature-74.png |
💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUIFilesDetails-fileDetails-feature-116.pngwebUIFilesDetails-fileDetails-feature-134.pngwebUIFilesDetails-fileDetails-feature-138.pngwebUIFilesDetails-fileDetails-feature-14.pngwebUIFilesDetails-fileDetails-feature-161.pngwebUIFilesDetails-fileDetails-feature-170.pngwebUIFilesDetails-fileDetails-feature-25.pngwebUIFilesDetails-fileDetails-feature-38.pngwebUIFilesDetails-fileDetails-feature-51.pngwebUIFilesDetails-fileDetails-feature-82.pngwebUIFilesDetails-fileDetails-feature-99.pngwebUIFilesList-fileList-feature-15.pngwebUIFilesList-fileList-feature-22.pngwebUIFilesList-fileList-feature-28.pngwebUIFilesList-fileList-feature-33.pngwebUIFilesList-fileList-feature-41.pngwebUIFilesList-fileList-feature-46.pngwebUIFilesList-fileList-feature-51.pngwebUIFilesList-fileList-feature-60.pngwebUIFilesList-fileList-feature-73.pngwebUIFilesList-sort-feature-31.pngwebUIFilesList-sort-feature-51.pngwebUIFilesList-sort-feature-72.pngwebUIFilesSearch-search-feature-103.pngwebUIFilesSearch-search-feature-113.pngwebUIFilesSearch-search-feature-122.pngwebUIFilesSearch-search-feature-153.pngwebUIFilesSearch-search-feature-165.pngwebUIFilesSearch-search-feature-175.pngwebUIFilesSearch-search-feature-184.pngwebUIFilesSearch-search-feature-27.pngwebUIFilesSearch-search-feature-38.pngwebUIFilesSearch-search-feature-50.pngwebUIFilesSearch-search-feature-95.png |
💥 Acceptance tests ResharingToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUIResharingToRoot-reshareUsers-feature-119.pngwebUIResharingToRoot-reshareUsers-feature-132.pngwebUIResharingToRoot-reshareUsers-feature-138.pngwebUIResharingToRoot-reshareUsers-feature-145.pngwebUIResharingToRoot-reshareUsers-feature-152.pngwebUIResharingToRoot-reshareUsers-feature-16.pngwebUIResharingToRoot-reshareUsers-feature-160.pngwebUIResharingToRoot-reshareUsers-feature-177.pngwebUIResharingToRoot-reshareUsers-feature-195.pngwebUIResharingToRoot-reshareUsers-feature-203.pngwebUIResharingToRoot-reshareUsers-feature-215.pngwebUIResharingToRoot-reshareUsers-feature-227.pngwebUIResharingToRoot-reshareUsers-feature-241.pngwebUIResharingToRoot-reshareUsers-feature-25.pngwebUIResharingToRoot-reshareUsers-feature-250.pngwebUIResharingToRoot-reshareUsers-feature-34.pngwebUIResharingToRoot-reshareUsers-feature-56.pngwebUIResharingToRoot-reshareUsers-feature-57.pngwebUIResharingToRoot-reshareUsers-feature-58.pngwebUIResharingToRoot-reshareUsers-feature-59.pngwebUIResharingToRoot-reshareUsers-feature-60.pngwebUIResharingToRoot-reshareUsers-feature-88.pngwebUIResharingToRoot-reshareUsers-feature-89.pngwebUIResharingToRoot-reshareUsers-feature-90.pngwebUIResharingToRoot-reshareUsers-feature-91.pngwebUIResharingToRoot-reshareUsers-feature-92.pngwebUIResharingToRoot-reshareUsers-feature-95.png |
💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingInternalGroupsToRoot-shareWithGroups-feature-128.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-234.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-69.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-70.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-71.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-74.pngwebUISharingInternalGroupsToRoot-shareWithGroups-feature-95.png |
💥 Acceptance tests SharingPublicBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUISharingPublicBasic-publicLinkCreate-feature-102.pngwebUISharingPublicBasic-publicLinkCreate-feature-120.pngwebUISharingPublicBasic-publicLinkCreate-feature-138.pngwebUISharingPublicBasic-publicLinkCreate-feature-177.pngwebUISharingPublicBasic-publicLinkEdit-feature-102.pngwebUISharingPublicBasic-publicLinkEdit-feature-116.pngwebUISharingPublicBasic-publicLinkEdit-feature-131.pngwebUISharingPublicBasic-publicLinkEdit-feature-146.pngwebUISharingPublicBasic-publicLinkEdit-feature-161.pngwebUISharingPublicBasic-publicLinkEdit-feature-181.pngwebUISharingPublicBasic-publicLinkEdit-feature-204.pngwebUISharingPublicBasic-publicLinkEdit-feature-30.pngwebUISharingPublicBasic-publicLinkEdit-feature-31.pngwebUISharingPublicBasic-publicLinkEdit-feature-32.pngwebUISharingPublicBasic-publicLinkEdit-feature-33.pngwebUISharingPublicBasic-publicLinkEdit-feature-56.pngwebUISharingPublicBasic-publicLinkEdit-feature-57.pngwebUISharingPublicBasic-publicLinkEdit-feature-58.pngwebUISharingPublicBasic-publicLinkEdit-feature-59.pngwebUISharingPublicBasic-publicLinkEdit-feature-82.pngwebUISharingPublicBasic-publicLinkEdit-feature-83.pngwebUISharingPublicBasic-publicLinkEdit-feature-84.pngwebUISharingPublicBasic-publicLinkEdit-feature-85.pngwebUISharingPublicBasic-publicLinkEdit-feature-88.png |
💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15516/
webUIRenameFiles-renameFiles-feature-117.pngwebUIRenameFiles-renameFiles-feature-118.pngwebUIRenameFiles-renameFiles-feature-119.pngwebUIRenameFiles-renameFiles-feature-138.pngwebUIRenameFiles-renameFiles-feature-139.pngwebUIRenameFiles-renameFiles-feature-143.pngwebUIRenameFiles-renameFiles-feature-151.pngwebUIRenameFiles-renameFiles-feature-157.pngwebUIRenameFiles-renameFiles-feature-163.pngwebUIRenameFiles-renameFiles-feature-169.pngwebUIRenameFiles-renameFiles-feature-176.pngwebUIRenameFiles-renameFiles-feature-186.pngwebUIRenameFiles-renameFiles-feature-202.pngwebUIRenameFiles-renameFiles-feature-22.pngwebUIRenameFiles-renameFiles-feature-227.pngwebUIRenameFiles-renameFiles-feature-23.pngwebUIRenameFiles-renameFiles-feature-24.pngwebUIRenameFiles-renameFiles-feature-249.pngwebUIRenameFiles-renameFiles-feature-25.pngwebUIRenameFiles-renameFiles-feature-26.pngwebUIRenameFiles-renameFiles-feature-260.pngwebUIRenameFiles-renameFiles-feature-38.pngwebUIRenameFiles-renameFiles-feature-39.pngwebUIRenameFiles-renameFiles-feature-40.pngwebUIRenameFiles-renameFiles-feature-43.pngwebUIRenameFiles-renameFiles-feature-62.pngwebUIRenameFiles-renameFiles-feature-77.pngwebUIRenameFiles-renameFiles-feature-90.pngwebUIRenameFiles-renameFilesInsideProblematicFolderName-feature-21.pngwebUIRenameFiles-renameFilesInsideProblematicFolderName-feature-22.pngwebUIRenameFiles-renameFilesInsideProblematicFolderName-feature-36.pngwebUIRenameFolders-renameFolders-feature-107.pngwebUIRenameFolders-renameFolders-feature-108.pngwebUIRenameFolders-renameFolders-feature-109.pngwebUIRenameFolders-renameFolders-feature-122.pngwebUIRenameFolders-renameFolders-feature-127.pngwebUIRenameFolders-renameFolders-feature-132.pngwebUIRenameFolders-renameFolders-feature-138.pngwebUIRenameFolders-renameFolders-feature-147.pngwebUIRenameFolders-renameFolders-feature-22.pngwebUIRenameFolders-renameFolders-feature-23.pngwebUIRenameFolders-renameFolders-feature-24.pngwebUIRenameFolders-renameFolders-feature-25.pngwebUIRenameFolders-renameFolders-feature-26.pngwebUIRenameFolders-renameFolders-feature-38.pngwebUIRenameFolders-renameFolders-feature-39.pngwebUIRenameFolders-renameFolders-feature-40.pngwebUIRenameFolders-renameFolders-feature-43.pngwebUIRenameFolders-renameFolders-feature-58.pngwebUIRenameFolders-renameFolders-feature-67.pngwebUIRenameFolders-renameFolders-feature-79.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some things (see comments). Two more:
- computed prop
accessibleLabel
is not needed anymore and can be deleted - the font weight of the nav items in the sidebar is different than before. Before it was bold, now it's not.
need to make an ODS PR for that... |
@kulmann Ready for another round |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
💥 Acceptance tests webUINotificationBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15539/
webUINotifications-displayNotificationsOnWebUI-feature-18.png |
In the new sidebar content is defined solely via slots. We've moved all the content into those slots so that the sidebar still gets displayed correctly.