-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
background loading for avatars #5073
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! Needs some tests and then we're ready to go 🎯
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15394/
webUIMoveFilesFolders-moveFiles-feature-105.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat improvement 😍
Description
if you had many file shares the avatar loading took a long period of time and blocked the ui, thats the nature os async await. This introduces a async / await background loading using iife.
The avatars now getting displayed initially with the initials and then get updated once loaded.
Related Issue
Motivation and Context
get the fileslist view rendered non blocking
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: