Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

background loading for avatars #5073

Merged
merged 6 commits into from
May 11, 2021
Merged

background loading for avatars #5073

merged 6 commits into from
May 11, 2021

Conversation

fschade
Copy link
Contributor

@fschade fschade commented May 6, 2021

Description

if you had many file shares the avatar loading took a long period of time and blocked the ui, thats the nature os async await. This introduces a async / await background loading using iife.

The avatars now getting displayed initially with the initials and then get updated once loaded.

Related Issue

Motivation and Context

get the fileslist view rendered non blocking

How Has This Been Tested?

  • test environment:
  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Changelog
  • Tests

@fschade fschade requested review from kulmann and pascalwengerter May 6, 2021 13:53
@fschade fschade self-assigned this May 6, 2021
@update-docs
Copy link

update-docs bot commented May 6, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Needs some tests and then we're ready to go 🎯

This was referenced May 10, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15394/

webUIMoveFilesFolders-moveFiles-feature-105.png

webUIMoveFilesFolders-moveFiles-feature-105.png

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat improvement 😍

@kulmann kulmann marked this pull request as ready for review May 11, 2021 21:44
@kulmann kulmann requested a review from pascalwengerter May 11, 2021 21:49
@kulmann kulmann merged commit bc0774a into master May 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the lazy-avatars branch May 11, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send avatar requests in the background
4 participants