29042021 move tags into lists #5043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can someone review this with OC10 + resharing activated? My setup is broken regarding this currently 🥴 |
pascalwengerter
force-pushed
the
a11y-swarming
branch
from
cc92b31 to
8fd6fa9
Compare
|
Can you rebase this PR? |
pascalwengerter
force-pushed
the
29042021_move-tags-into-lists
branch
from
e3d34c2 to
d02eb85
Compare
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15306/
|
💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15306/
|
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15306/
|
💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15306/
|
💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15306/
|
kulmann
requested changes
May 11, 2021
packages/web-app-files/src/components/Collaborators/Collaborator.vue
Outdated
Show resolved
Hide resolved
pascalwengerter
force-pushed
the
a11y-swarming
branch
from
8a2284f to
9c69cd3
Compare
add vue-axe to see a11y violations in the console while developing add eslint rule from vue-a11y project to get linting errors on accessibility violations
pascalwengerter
force-pushed
the
29042021_move-tags-into-lists
branch
from
3360c64 to
2d1f051
Compare
|
Rebased again and ready for re-review @kulmann |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See changelog