Remove autoclose on notifications #5040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using a draft for now until we eventually decided on where the timeout should be handled (component <> Web). |
pascalwengerter
force-pushed
the
a11y-swarming
branch
from
cc92b31 to
8fd6fa9
Compare
AlexAndBear
force-pushed
the
remove-autoclose-on-notifications
branch
from
4091aff to
782ab67
Compare
💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15233/
|
💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15233/
|
💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15233/
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove autoclose on notifications as we handle this in the component with owncloud/owncloud-design-system#1247.
Types of changes
Checklist: