Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove autoclose on notifications #5040

Merged
merged 2 commits into from
May 5, 2021

Conversation

JammingBen
Copy link
Contributor

Description

Remove autoclose on notifications as we handle this in the component with owncloud/owncloud-design-system#1247.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen
Copy link
Contributor Author

Using a draft for now until we eventually decided on where the timeout should be handled (component <> Web).

@AlexAndBear AlexAndBear force-pushed the remove-autoclose-on-notifications branch from 4091aff to 782ab67 Compare April 30, 2021 07:58
@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15233/

20210430-081044-311.png
20210430-081115-808.png
20210430-081148-320.png
20210430-081222-436.png
20210430-081255-481.png
20210430-081327-952.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15233/

20210430-080945-530.png
20210430-081016-737.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15233/

20210430-081154-707.png
20210430-081225-908.png
20210430-081256-163.png
20210430-081326-465.png

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owncloud owncloud deleted a comment from update-docs bot May 5, 2021
@JammingBen JammingBen marked this pull request as ready for review May 5, 2021 06:23
@JammingBen JammingBen merged commit 950d17c into a11y-swarming May 5, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-autoclose-on-notifications branch May 5, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants