Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: display navigation for resolved private link #5023

Merged
merged 1 commit into from
Apr 26, 2021
Merged

fix: display navigation for resolved private link #5023

merged 1 commit into from
Apr 26, 2021

Conversation

LukasHirt
Copy link
Collaborator

Description

We've fixed that the navigation in the left sidebar is visible for a resolved private link as well

How Has This Been Tested?

  • test environment: Chrome
  • test case 1: Visit a private link for resource in the root level
  • test case 2: Visit a private link for a nested resource

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Apr 26, 2021
@LukasHirt LukasHirt requested a review from kulmann April 26, 2021 12:17
@LukasHirt LukasHirt self-assigned this Apr 26, 2021
@LukasHirt LukasHirt merged commit 66d5fa4 into master Apr 26, 2021
@LukasHirt LukasHirt deleted the fix/private-link-nav branch April 26, 2021 14:20
@individual-it individual-it mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @kulmann