-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move breadcrumbs out of location picker heading #5020
Move breadcrumbs out of location picker heading #5020
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
I'm trying to think about the table... it has different padding than anything above it. Updating ODS with prop for padding of the table would again just increase the effort & time needed but I do not want to decrease the padding from elements above as that looks like 💩 |
There's more - the horizontal line above has a slight margin left and right, while the borders of the table go from left to right without margin. Could you check if applying that same margin to the left and right of the table makes it look better? If not, then I'd be all in for making the padding left and right slightly bigger in the ODS component. |
In the |
8458526
to
eed3960
Compare
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15125/
|
4c2cb18
to
d24b543
Compare
@kulmann I would say it's ready for review. We need an ODS update for the padding improvement, but we do not need to touch anything after that so I wouldn't really block this PR because of that. |
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15128/
|
💥 Acceptance tests Move failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/15129/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
We've moved the breadcrumbs element out of the location picker heading and moved it under it.
The heading is now also reflecting the page title.
We've also decreased the size of both breadcrumbs and action buttons so that they fit better together.
Screenshots (if appropriate):
Types of changes