Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Get share indicators of a resource with retry #4976

Merged
merged 2 commits into from
Apr 21, 2021
Merged

[Tests-Only] Get share indicators of a resource with retry #4976

merged 2 commits into from
Apr 21, 2021

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Apr 16, 2021 •
edited by saw-jan
Loading

Description

This PR adds functionality to try to get share indicator of a resource a second time when the first try fails
Hopefully, it will prevent intermittent fails of the sharing-indicator tests that occur due to the unavailability of share indicators.

Related Issue

How Has This Been Tested?

  • test environment: 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsRootSharingIndicator2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14721/

20210416-090536-609.png

@dpakach dpakach force-pushed the debug-intermittent-tests branch 3 times, most recently from b51c157 to ece125d Compare April 16, 2021 11:47
@dpakach
Copy link
Contributor Author

dpakach commented Apr 18, 2021 •
edited
Loading

This approach kinda works eg. https://drone.owncloud.com/owncloud/web/14753/7/14 (line number 503)
It may be worth adding
cc @jasson99

@saw-jan saw-jan force-pushed the debug-intermittent-tests branch 4 times, most recently from 1cfc857 to 5b01192 Compare April 19, 2021 06:50
@saw-jan saw-jan self-assigned this Apr 19, 2021
@saw-jan saw-jan force-pushed the debug-intermittent-tests branch 2 times, most recently from 12c7d63 to 77ccbf8 Compare April 19, 2021 09:07
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14802/

20210419-092426-374.png
20210419-092455-779.png
20210419-092524-489.png
20210419-092552-692.png
20210419-092745-211.png
20210419-092818-477.png

@saw-jan saw-jan force-pushed the debug-intermittent-tests branch 2 times, most recently from 1f4ce8b to a34ffcc Compare April 19, 2021 11:02
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14812/

20210419-110935-654.png
20210419-111008-518.png
20210419-111152-251.png
20210419-111224-629.png
20210419-111759-515.png
20210419-111912-400.png
20210419-111944-360.png
20210419-112739-572.png
20210419-112824-815.png
20210419-112857-800.png

@saw-jan saw-jan force-pushed the debug-intermittent-tests branch from a34ffcc to 20fe9c5 Compare April 20, 2021 03:30
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRenameFiles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14834/

20210420-034121-943.png
20210420-034156-012.png
20210420-034229-649.png
20210420-034302-554.png
20210420-034335-752.png
20210420-034409-043.png
20210420-034442-146.png
20210420-034515-108.png
20210420-034548-847.png
20210420-034622-193.png
20210420-034809-660.png
20210420-034842-129.png
20210420-035116-636.png
20210420-035149-113.png
20210420-035549-876.png
20210420-035622-430.png
20210420-035654-932.png
20210420-035727-469.png
20210420-035759-960.png
20210420-035832-377.png
20210420-035904-752.png
20210420-035937-135.png
20210420-040029-610.png
20210420-040101-967.png
20210420-040246-074.png
20210420-040318-634.png
20210420-040554-387.png

@saw-jan saw-jan force-pushed the debug-intermittent-tests branch from 20fe9c5 to b7e8e77 Compare April 20, 2021 04:51
@saw-jan saw-jan changed the title debug failing tests [Tests-Only] Get share indicators of a resource with retry Apr 20, 2021
@owncloud owncloud deleted a comment from update-docs bot Apr 20, 2021
@saw-jan saw-jan marked this pull request as ready for review April 20, 2021 04:57
haribhandari07
haribhandari07 reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@haribhandari07 haribhandari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swoichha swoichha requested a review from individual-it April 20, 2021 08:53
@saw-jan saw-jan force-pushed the debug-intermittent-tests branch from b7e8e77 to 52cc593 Compare April 21, 2021 06:20
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14898/

20210421-063437-637.png
20210421-063512-418.png
20210421-063547-674.png
20210421-063622-833.png
20210421-063900-674.png
20210421-063936-449.png

jasson99
jasson99 reviewed Apr 21, 2021
View reviewed changes
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan force-pushed the debug-intermittent-tests branch from 52cc593 to 0b0df4e Compare April 21, 2021 07:40
@individual-it individual-it force-pushed the debug-intermittent-tests branch from 0b0df4e to 4005761 Compare April 21, 2021 07:40
@individual-it
Copy link
Member

I've rebased on master

@saw-jan saw-jan merged commit 5b90c5d into master Apr 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the debug-intermittent-tests branch April 21, 2021 08:24
@saw-jan saw-jan mentioned this pull request Apr 21, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasson99 jasson99 jasson99 left review comments

@haribhandari07 haribhandari07 haribhandari07 left review comments

@individual-it individual-it individual-it approved these changes

@swoichha swoichha Awaiting requested review from swoichha

@Talank Talank Awaiting requested review from Talank

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dpakach @ownclouders @individual-it @haribhandari07 @jasson99 @saw-jan