New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Set background color from ODS CSS variable #4805

Closed

pascalwengerter wants to merge 1 commit into master from 11032021_fix_4331

Contributor

pascalwengerter commented Mar 11, 2021

Description

Explicitly setting the background color in the main web app layout through a CSS variable (introduced in the next ODS release).

Related Issue

Fixes Audit #1 – General Overview when logged in – Main layout column on desktop has no explicit background color #4331

Motivation and Context

Solves an offense in regards of accessibility.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Open tasks:

Confirm that it works once the next release of the ODS is merged into web


          Set background color from ODS CSS variable

f198adc

Contributor Author

pascalwengerter commented Mar 25, 2021

Issue #4331 will get fixed in #4862, closing this in favor of never PR

pascalwengerter closed this

pascalwengerter deleted the 11032021_fix_4331 branch

March 30, 2021 13:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet