Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress redirect error #4759

Merged
merged 1 commit into from
Feb 19, 2021
Merged

Supress redirect error #4759

merged 1 commit into from
Feb 19, 2021

Conversation

LukasHirt
Copy link
Collaborator

We've suppressed the error appearing in the console which warned about redirect happening after the oidc callback page. This error is being shown because after the oidc callback has successfully processed the authorization request we are redirecting to the / path which immediately does another redirect to the extension set as default one. In the context of Vue router, this is considered an error even though for us it is a valid use case. The error is only informative thus no issue is going to surface if we suppress it. This way we are getting closer to a clean console without errors.

@LukasHirt LukasHirt requested a review from kulmann February 19, 2021 09:29
@LukasHirt LukasHirt self-assigned this Feb 19, 2021
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LukasHirt LukasHirt merged commit 91dc7ec into master Feb 19, 2021
@LukasHirt LukasHirt deleted the surpress-redirect-error branch February 19, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants