-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] Convert expected failure text file to markdown #4612
Conversation
6fe37f8
to
71ae1bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. run.sh
can first filter the file and just select line that begin with -
and then easily extract the characters between the first pair of []
. Those are the expected-failures.
Everything else is free-form Markdown, so people can do what they like to make the document "look nice".
71ae1bb
to
1cb4a78
Compare
1cb4a78
to
220c2eb
Compare
220c2eb
to
512e762
Compare
512e762
to
16b808d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@haribhandari07 this looks good. There is flexibility for people to add whatever free text they like to the expected-failures files, put markdown headings etc. So we can merge this when CI passes. Do you have a script for converting the old-format expected failures file? (or maybe it just needs the file from here to be pasted into And make a PR that bumps the commit id (after this PR is merged) |
Description
This PR converts expected failure text file to a markdown file.
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: