Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Convert expected failure text file to markdown #4612

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

haribhandari07
Copy link
Contributor

@haribhandari07 haribhandari07 commented Jan 14, 2021

Description

This PR converts expected failure text file to a markdown file.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI
  • Manual

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@haribhandari07 haribhandari07 force-pushed the markdown-expected-failures branch from 6fe37f8 to 71ae1bb Compare January 14, 2021 10:41
@phil-davis phil-davis changed the title Convert expected failure text file to markdown [tests-only] Convert expected failure text file to markdown Jan 14, 2021
@owncloud owncloud deleted a comment from update-docs bot Jan 14, 2021
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. run.sh can first filter the file and just select line that begin with - and then easily extract the characters between the first pair of []. Those are the expected-failures.

Everything else is free-form Markdown, so people can do what they like to make the document "look nice".

@haribhandari07 haribhandari07 force-pushed the markdown-expected-failures branch from 71ae1bb to 1cb4a78 Compare January 15, 2021 07:42
tests/acceptance/run.sh Outdated Show resolved Hide resolved
tests/acceptance/run.sh Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review January 15, 2021 08:20
@haribhandari07 haribhandari07 force-pushed the markdown-expected-failures branch from 1cb4a78 to 220c2eb Compare January 15, 2021 08:31
tests/acceptance/run.sh Outdated Show resolved Hide resolved
@phil-davis phil-davis self-requested a review January 15, 2021 08:35
@haribhandari07 haribhandari07 force-pushed the markdown-expected-failures branch from 220c2eb to 512e762 Compare January 15, 2021 08:37
@haribhandari07 haribhandari07 self-assigned this Jan 15, 2021
@haribhandari07 haribhandari07 marked this pull request as ready for review January 15, 2021 08:37
@haribhandari07 haribhandari07 added Status:Needs-Review Needs review from a maintainer QA:team labels Jan 15, 2021
tests/acceptance/run.sh Outdated Show resolved Hide resolved
@haribhandari07 haribhandari07 force-pushed the markdown-expected-failures branch from 512e762 to 16b808d Compare January 15, 2021 10:17
@phil-davis phil-davis self-requested a review January 15, 2021 10:27
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

@haribhandari07 this looks good. There is flexibility for people to add whatever free text they like to the expected-failures files, put markdown headings etc. So we can merge this when CI passes.

Do you have a script for converting the old-format expected failures file?
Can you do that for https://github.com/owncloud/ocis/blob/master/tests/acceptance/expected-failures-webUI-on-OWNCLOUD-storage.txt ?

(or maybe it just needs the file from here to be pasted into owncloud/ocis)

And make a PR that bumps the commit id (after this PR is merged)

@phil-davis phil-davis merged commit bd071e4 into master Jan 15, 2021
@delete-merged-branch delete-merged-branch bot deleted the markdown-expected-failures branch January 15, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants