Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Add ui test for checking the browser session of deleted user #4543

Merged
merged 1 commit into from
Dec 29, 2020
Merged

[Tests-Only] Add ui test for checking the browser session of deleted user #4543

merged 1 commit into from
Dec 29, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Dec 22, 2020 •
edited
Loading

Description

Add webUI tests for owncloud/ocis#1129

The tests currently doesn't passes due to #4564

Related Issue

Motivation and Context

How Has This Been Tested?

🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach changed the title [Tests-Only] Add ui test for checking the browser session of deleted … [Tests-Only] Add ui test for checking the browser session of deleted user Dec 22, 2020
@dpakach dpakach mentioned this pull request Dec 23, 2020
Closed
@dpakach dpakach force-pushed the test-user-session branch 2 times, most recently from 889154c to 307902b Compare December 29, 2020 06:01
@dpakach dpakach requested review from individual-it and phil-davis and removed request for individual-it December 29, 2020 06:02
@dpakach dpakach self-assigned this Dec 29, 2020
@dpakach dpakach added the Status:Needs-Review Needs review from a maintainer label Dec 29, 2020
@dpakach dpakach marked this pull request as ready for review December 29, 2020 06:03
phil-davis
phil-davis reviewed Dec 29, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And needs rebase to resolve conflicts.

tests/acceptance/expected-failures-with-oc10-server.txt Outdated Show resolved Hide resolved
tests/acceptance/expected-failures-with-ocis-server-owncloud-storage.txt Outdated Show resolved Hide resolved
@dpakach dpakach merged commit 62d3be6 into master Dec 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the test-user-session branch December 29, 2020 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@dpakach dpakach

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpakach @phil-davis @individual-it