Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Change more phoenix to web now that owncloud/ocis has web extension #4485

Merged
merged 2 commits into from
Dec 14, 2020

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Dec 14, 2020

Description

PR owncloud/ocis#1041 switched owncloud/ocis to having a web extension, rather than ocis-phoenix

Adjust CI here so that it understands the changes in owncloud/ocis

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis self-assigned this Dec 14, 2020
@phil-davis phil-davis force-pushed the change-more-phoenix-to-web branch 2 times, most recently from 0c39d6f to b39239a Compare December 14, 2020 03:26
@phil-davis phil-davis marked this pull request as ready for review December 14, 2020 06:23
.drone.star Show resolved Hide resolved
.drone.star Show resolved Hide resolved
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@phil-davis
Copy link
Contributor Author

I broke it in the last 3 commits - I need to either sort out why, or remove those commits for now.

@phil-davis phil-davis force-pushed the change-more-phoenix-to-web branch from a30ebb1 to ac4bc41 Compare December 14, 2020 08:33
@phil-davis phil-davis force-pushed the change-more-phoenix-to-web branch from ac4bc41 to d87505b Compare December 14, 2020 08:34
@phil-davis
Copy link
Contributor Author

I need to either sort out why, or remove those commits for now.

I removed those commits and squashed a bit. This should pass now.

In a separate PR I will try to sort out what the acceptance tests against an oC10 server are really testing. I think that is an issue that has been there since before the phoenix->web change.

This was referenced Dec 14, 2020
@phil-davis phil-davis merged commit 91a71c2 into master Dec 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the change-more-phoenix-to-web branch December 14, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants