Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] update ocis commitid for running acceptance tests #4285

Merged
merged 1 commit into from
Nov 11, 2020
Merged

[Tests-Only] update ocis commitid for running acceptance tests #4285

merged 1 commit into from
Nov 11, 2020

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 6, 2020 •
edited
Loading

Description

Update the ocis commit id for running tests.

Related Issue

  • ocis server out of date

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@dpakach dpakach force-pushed the bump-ocis-cid branch 3 times, most recently from f987638 to b42f1cc Compare November 9, 2020 05:45
@dpakach dpakach self-assigned this Nov 11, 2020
@dpakach dpakach added Status:Needs-Review Needs review from a maintainer QA:team labels Nov 11, 2020
@dpakach dpakach marked this pull request as ready for review November 11, 2020 03:43
phil-davis
phil-davis approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - you found all the magic environment variables that had to be changed!

@phil-davis phil-davis merged commit 645d91f into master Nov 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the bump-ocis-cid branch November 11, 2020 03:56
@phil-davis phil-davis mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@dpakach dpakach

Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dpakach @phil-davis