Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default apps in example configs #4155

Merged
merged 1 commit into from
Oct 13, 2020
Merged

Default apps in example configs #4155

merged 1 commit into from
Oct 13, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Oct 12, 2020

Description

We only want to have "files" and "media-viewer" as default apps in the example configs.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Oct 12, 2020
@kulmann kulmann requested a review from LukasHirt October 12, 2020 12:12
@kulmann kulmann self-assigned this Oct 12, 2020
@kulmann kulmann requested a review from pmaier1 October 12, 2020 13:59
pmaier1
pmaier1 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@kulmann kulmann merged commit b261e9a into master Oct 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the default-configs branch October 13, 2020 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmaier1 pmaier1 pmaier1 approved these changes

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kulmann @pmaier1