Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files lists loading state #4099

Merged
merged 5 commits into from
Sep 24, 2020
Merged

Files lists loading state #4099

merged 5 commits into from
Sep 24, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Sep 22, 2020

Description

We removed the oc-loader component at the top of the different variations of the files list view and introduced a spinner + one line of text to the center of the screen.

How Has This Been Tested?

Drone

Screenshots (if appropriate):

Screenshot 2020-09-22 at 13 02 34

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from LukasHirt September 22, 2020 15:40
@kulmann kulmann self-assigned this Sep 22, 2020
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LukasHirt LukasHirt force-pushed the files-lists-loading-state branch from d556255 to 78bf477 Compare September 22, 2020 16:14
@LukasHirt
Copy link
Collaborator

The drone didn't pick up this PR because of emoji in the description. Changed the last commit message and pushed it to trigger it again.

@LukasHirt
Copy link
Collaborator

Had to revert the import of lodash in actions because of the chain. Webpack import was failing otherwise.

@LukasHirt LukasHirt force-pushed the files-lists-loading-state branch from a06e385 to bfe268a Compare September 23, 2020 21:59
@LukasHirt LukasHirt merged commit a8d2821 into master Sep 24, 2020
@LukasHirt LukasHirt deleted the files-lists-loading-state branch September 24, 2020 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants