Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember public link password on page refresh (alternative) #4084

Merged

Conversation

PVince81
Copy link
Contributor

Simpler alternative to #4083

Description

When refreshing the page in the file list of a public link share,
the user doesn't need to enter the password again. This only applies for the current page
and the password is forgotten by the browser again upon closing or switching to another site.

Related Issue

Part 8b of owncloud/product#231

Motivation and Context

How Has This Been Tested?

After entering password on public link page:

  • TEST: refresh the page doesn't ask for password again
  • TEST: closing page and opening the URL again asks for the URL again (so password is forgotten correctly)
  • TEST: change public link password to create a discrepancy with saved one: password is asked again

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

When refreshing the page in the file list of a public link share,
the user doesn't need to enter the password again. This only applies for the current page
and the password is forgotten by the browser again upon closing or switching to another site.
@PVince81 PVince81 requested a review from LukasHirt September 18, 2020 10:36
@PVince81 PVince81 self-assigned this Sep 18, 2020
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@PVince81 PVince81 merged commit fb63b1c into master Sep 18, 2020
@pascalwengerter pascalwengerter deleted the public-link-remember-password-on-refresh-alternative branch April 8, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants